Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rulesets): add instance key to ruleset #1157

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

wsan3
Copy link
Contributor

@wsan3 wsan3 commented Jul 9, 2024

Description

  • Add instance key to ruleset tag
  • Enable steps to match and run on certain instances (e.g. dev vs prod)

Example

version: "1"

steps:
  - name: run step on production instance
    ruleset:
      event: push
      branch: main
      instance: https://octocat.prod.github.com
    image: alpine
    commands:
      - echo "this step ran on a production instance"

Related

go-vela/community#803

@wsan3 wsan3 added the feature Indicates a new feature label Jul 9, 2024
@wsan3 wsan3 self-assigned this Jul 9, 2024
@wsan3 wsan3 requested a review from a team as a code owner July 9, 2024 18:30
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.79%. Comparing base (d83c78e) to head (0af6469).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1157   +/-   ##
=======================================
  Coverage   52.78%   52.79%           
=======================================
  Files         551      551           
  Lines       19220    19221    +1     
=======================================
+ Hits        10146    10147    +1     
  Misses       8510     8510           
  Partials      564      564           
Files with missing lines Coverage Δ
compiler/native/compile.go 71.73% <100.00%> (+0.10%) ⬆️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit b6e5d75 into main Sep 12, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the feat/ruleset-instance branch September 12, 2024 13:54
wass3rw3rk added a commit to go-vela/docs that referenced this pull request Sep 30, 2024
ecrupper pushed a commit to go-vela/docs that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants