Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci/deps): adjust renovate regex to auto-bump git image #1173

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Aug 30, 2024

this is not working. the regex included the digest sha as the tag version instead of extracting it separately. i tweaked it a bit and ran renovate locally to make sure it is accurately capturing and updating the dependency as intended.

note: i didn't bother updating the image. renovate opening a PR to update that dependency will be the test to confirm that it actually works :)

switched to use target/vela-git-slim as the default image and in the process updated to use the latest version of that.

i will open a similar PR on go-vela/cli

this was not working. the regex included the digest sha as the tag
version instead of extracting it separately. i tweaked it a bit and ran
renovate locally to make sure it is accurately capturing and updating
the dependency as intended.
@wass3r wass3r requested a review from a team as a code owner August 30, 2024 04:36
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.81%. Comparing base (89b0a4a) to head (c5e0eb8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/vela-server/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage   52.81%   52.81%           
=======================================
  Files         551      551           
  Lines       19211    19211           
=======================================
  Hits        10146    10146           
  Misses       8501     8501           
  Partials      564      564           
Files with missing lines Coverage Δ
mock/server/settings.go 0.00% <ø> (ø)
cmd/vela-server/main.go 0.00% <0.00%> (ø)

@vela81
Copy link

vela81 commented Aug 30, 2024 via email

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 372a430 into main Sep 6, 2024
13 of 14 checks passed
@ecrupper ecrupper deleted the fix/ci/autobumpgit branch September 6, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants