-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci/deps): adjust renovate regex to auto-bump git image #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was not working. the regex included the digest sha as the tag version instead of extracting it separately. i tweaked it a bit and ran renovate locally to make sure it is accurately capturing and updating the dependency as intended.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
=======================================
Coverage 52.81% 52.81%
=======================================
Files 551 551
Lines 19211 19211
=======================================
Hits 10146 10146
Misses 8501 8501
Partials 564 564
|
Read only any changes should be in express in writing
<abelvela>
On Thursday, August 29, 2024, 11:36 PM, david may ***@***.***> wrote:
this was not working. the regex included the digest sha as the tag version instead of extracting it separately. i tweaked it a bit and ran renovate locally to make sure it is accurately capturing and updating the dependency as intended.
i didn't bother updating the image. renovate opening a PR to update that dependency will be the test to confirm that it works :)
You can view, comment on, or merge this pull request online at:
#1173
Commit Summary
- c533c59 fix(ci/deps): adjust renovate regex to auto-bump git image
File Changes
(2 files)
- M .github/renovate.json (5)
- M cmd/vela-server/main.go (3)
Patch Links:
- https://github.com/go-vela/server/pull/1173.patch
- https://github.com/go-vela/server/pull/1173.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
KellyMerrick
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ecrupper
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is not working. the regex included the digest sha as the tag version instead of extracting it separately. i tweaked it a bit and ran renovate locally to make sure it is accurately capturing and updating the dependency as intended.
note: i didn't bother updating the image. renovate opening a PR to update that dependency will be the test to confirm that it actually works :)switched to use target/vela-git-slim as the default image and in the process updated to use the latest version of that.
i will open a similar PR on go-vela/cli