Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(steps/services): use server API types for steps and services #1210

Merged
merged 2 commits into from
Oct 18, 2024

gci

afd5d78
Select commit
Loading
Failed to load commit list.
Merged

refactor(steps/services): use server API types for steps and services #1210

gci
afd5d78
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 18, 2024 in 0s

56.35% (target 90.00%)

View this Pull Request on Codecov

56.35% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 93.79699% with 66 lines in your changes missing coverage. Please review.

Project coverage is 56.35%. Comparing base (37f2c35) to head (afd5d78).

Files with missing lines Patch % Lines
api/types/service.go 87.10% 30 Missing and 15 partials ⚠️
api/build/graph.go 0.00% 5 Missing ⚠️
api/step/plan.go 0.00% 4 Missing ⚠️
api/service/plan.go 0.00% 3 Missing ⚠️
api/build/update.go 0.00% 2 Missing ⚠️
api/admin/service.go 0.00% 1 Missing ⚠️
api/admin/step.go 0.00% 1 Missing ⚠️
api/build/clean.go 0.00% 1 Missing ⚠️
api/service/create.go 0.00% 1 Missing ⚠️
api/service/update.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1210      +/-   ##
==========================================
+ Coverage   55.17%   56.35%   +1.17%     
==========================================
  Files         586      590       +4     
  Lines       31488    32438     +950     
==========================================
+ Hits        17374    18279     +905     
- Misses      13500    13530      +30     
- Partials      614      629      +15     
Files with missing lines Coverage Δ
api/admin/clean.go 0.00% <ø> (ø)
api/admin/worker.go 0.00% <ø> (ø)
api/auth/logout.go 0.00% <ø> (ø)
api/auth/post_token.go 0.00% <ø> (ø)
api/badge.go 0.00% <ø> (ø)
api/build/approve.go 0.00% <ø> (ø)
api/build/auto_cancel.go 16.48% <ø> (ø)
api/build/cancel.go 0.00% <ø> (ø)
api/build/compile_publish.go 0.00% <ø> (ø)
api/build/list_org.go 0.00% <ø> (ø)
... and 203 more

... and 1 file with indirect coverage changes