Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ruleset)!: improve match code efficiency and properly handle status #1255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

refactor match code

fc8d0a5
Select commit
Loading
Failed to load commit list.
Open

refactor(ruleset)!: improve match code efficiency and properly handle status #1255

refactor match code
fc8d0a5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 18, 2025 in 0s

56.65% (target 90.00%)

View this Pull Request on Codecov

56.65% (target 90.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.65%. Comparing base (cf8aea3) to head (fc8d0a5).

❌ Your project check has failed because the head coverage (56.65%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
+ Coverage   56.59%   56.65%   +0.06%     
==========================================
  Files         629      629              
  Lines       35645    35598      -47     
==========================================
- Hits        20172    20167       -5     
+ Misses      14792    14764      -28     
+ Partials      681      667      -14     
Files with missing lines Coverage Δ
compiler/native/compile.go 70.37% <100.00%> (+0.06%) ⬆️
compiler/types/pipeline/container.go 83.67% <100.00%> (+0.75%) ⬆️
compiler/types/pipeline/ruleset.go 100.00% <100.00%> (+21.71%) ⬆️
compiler/types/pipeline/secret.go 94.59% <100.00%> (ø)
compiler/types/pipeline/stage.go 96.34% <100.00%> (ø)
compiler/types/yaml/buildkite/ruleset.go 83.81% <100.00%> (+1.99%) ⬆️
compiler/types/yaml/yaml/ruleset.go 66.21% <100.00%> (+3.21%) ⬆️