Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch(compiler): put local templates into the compiler engine struct #917

Merged
merged 1 commit into from
Jul 27, 2023
Merged

patch(compiler): put local templates into the compiler engine struct #917

merged 1 commit into from
Jul 27, 2023

Conversation

ecrupper
Copy link
Contributor

Ref: #916

@ecrupper ecrupper requested a review from a team as a code owner July 27, 2023 14:01
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #917 (26859ce) into v0.20.1 (af55191) will increase coverage by 0.10%.
The diff coverage is 34.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.20.1     #917      +/-   ##
===========================================
+ Coverage    71.47%   71.57%   +0.10%     
===========================================
  Files          304      304              
  Lines        12450    12438      -12     
===========================================
+ Hits          8899     8903       +4     
+ Misses        3120     3106      -14     
+ Partials       431      429       -2
Files Changed Coverage Δ
compiler/native/expand.go 71.23% <0.00%> (-2.96%) ⬇️
compiler/native/compile.go 67.91% <100.00%> (+4.25%) ⬆️
compiler/native/native.go 86.27% <100.00%> (+0.56%) ⬆️

KellyMerrick
KellyMerrick approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 6edfe93 into v0.20.1 Jul 27, 2023
9 of 10 checks passed
@ecrupper ecrupper deleted the patch/local-compilation branch July 27, 2023 14:20
@ecrupper ecrupper mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@timhuynh94 timhuynh94 timhuynh94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecrupper @timhuynh94 @KellyMerrick @wass3rw3rk