Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add context to build functions #922

Merged
merged 3 commits into from
Aug 11, 2023
Merged

chore: add context to build functions #922

merged 3 commits into from
Aug 11, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 3, 2023

continuing the efforts started in #898

this is prep to add support for OpenTelemetry tracing.

the reason being, otel can (for the most part) work out of the box if you pass around contexts properly.

@plyr4 plyr4 requested a review from a team as a code owner August 3, 2023 14:40
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #922 (9064208) into main (516d4fe) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
- Coverage   71.42%   71.38%   -0.04%     
==========================================
  Files         304      304              
  Lines       12482    12500      +18     
==========================================
+ Hits         8915     8923       +8     
- Misses       3132     3142      +10     
  Partials      435      435              
Files Changed Coverage Δ
api/build/cancel.go 0.00% <0.00%> (ø)
api/build/clean.go 0.00% <0.00%> (ø)
api/build/create.go 0.00% <0.00%> (ø)
api/build/delete.go 0.00% <0.00%> (ø)
api/build/get_id.go 0.00% <0.00%> (ø)
api/build/list_org.go 0.00% <0.00%> (ø)
api/build/list_repo.go 0.00% <0.00%> (ø)
api/build/plan.go 0.00% <0.00%> (ø)
api/build/publish.go 0.00% <0.00%> (ø)
api/build/restart.go 0.00% <0.00%> (ø)
... and 24 more

@plyr4 plyr4 changed the title enhance: add context to Builds enhance: add context to build functions Aug 3, 2023
@plyr4 plyr4 changed the title enhance: add context to build functions chore: add context to build functions Aug 3, 2023
wass3rw3rk
wass3rw3rk previously approved these changes Aug 3, 2023
timhuynh94
timhuynh94 previously approved these changes Aug 3, 2023
@plyr4
Copy link
Contributor Author

plyr4 commented Aug 4, 2023

moving into draft until #898 is merged.
id rather take care of the conflicts than force them on sussman 😅

@plyr4 plyr4 marked this pull request as draft August 4, 2023 14:59
@plyr4 plyr4 marked this pull request as ready for review August 9, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants