fix(webhook): keep parent and build number synced #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, build number is always +1 to parent. for any new hooks coming in, parent and build number should be in sync. build restarts are the only instance where these should diverge to indicate which build was restarted.
Codecov Report
@@ Coverage Diff @@
## main #936 +/- ##
=======================================
Coverage 70.85% 70.85%
=======================================
Files 311 311
Lines 12841 12841
=======================================
Hits 9099 9099
Misses 3279 3279
Partials 463 463 |
wass3rw3rk
force-pushed
the
fix/parent-build-numbers
branch
from
cf7d4f2
to
3d62570
Compare
ecrupper
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, new builds always produce build objects that have their
parentfield referencing the previous build (-1) - the exception is the very first build for whichparentandnumberare the same value (1).afaik, there's no reason for this and the only time these two should diverge (at least, currently) is if a build was restarted. in that case
parentshould reference the build number that was restarted. that currently works as described.in other words, it currently looks like every build (except the very first one) is a restart of the previous build.
this change will remove the setting of the parent field on regular builds. for restarts it will continue to work as before and set the parent appropriately.