Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(webhook): improve on some comments during the webhook flow #944

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

ecrupper
Copy link
Contributor

An attempt at clearing some things up that may be confusing for first time contributors (or 50th time contributors for that matter 😅 )

@ecrupper ecrupper self-assigned this Aug 29, 2023
@ecrupper ecrupper requested a review from a team as a code owner August 29, 2023 14:26
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #944 (5cc8e3d) into main (20f3d92) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   70.83%   70.80%   -0.03%     
==========================================
  Files         311      311              
  Lines       12849    12854       +5     
==========================================
  Hits         9101     9101              
- Misses       3283     3288       +5     
  Partials      465      465              
Files Changed Coverage Δ
api/build/executable.go 0.00% <0.00%> (ø)
api/build/publish.go 0.00% <0.00%> (ø)

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 21ef21a into main Aug 30, 2023
11 of 12 checks passed
@ecrupper ecrupper deleted the enhance/webhook-comments branch August 30, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants