Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(db): return worker on created and updated #945

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

ecrupper
Copy link
Contributor

Final piece of this effort

@ecrupper ecrupper self-assigned this Aug 29, 2023
@ecrupper ecrupper requested a review from a team as a code owner August 29, 2023 15:10
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #945 (08304a1) into main (c8499cd) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   70.80%   70.79%   -0.01%     
==========================================
  Files         311      311              
  Lines       12854    12852       -2     
==========================================
- Hits         9101     9099       -2     
  Misses       3288     3288              
  Partials      465      465              
Files Changed Coverage Δ
compiler/registry/github/github.go 100.00% <ø> (ø)
compiler/registry/github/template.go 58.53% <ø> (ø)
scm/github/access.go 82.17% <ø> (ø)
scm/github/authentication.go 80.95% <ø> (ø)
scm/github/changeset.go 87.03% <ø> (ø)
scm/github/deployment.go 87.74% <ø> (ø)
scm/github/github.go 100.00% <ø> (ø)
scm/github/repo.go 76.34% <ø> (ø)
scm/github/webhook.go 85.88% <ø> (ø)
database/worker/create.go 85.00% <80.00%> (-0.72%) ⬇️
... and 1 more

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 7c23391 into main Aug 30, 2023
12 of 13 checks passed
@ecrupper ecrupper deleted the refactor-return-db-worker branch August 30, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants