Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(starlark): make execution step limit configurable #947

Merged
merged 11 commits into from
Aug 31, 2023
Merged

enhance(starlark): make execution step limit configurable #947

merged 11 commits into from
Aug 31, 2023

Commits on Aug 28, 2023

  1. Increase Starlark execution limit, abstract limit resolver 

    5,000 was too few to enable the example added to the testdata to work, so was 6,000. I chose 7,500 arbitrarily after a test at 10,000 and both worked.

In the long term, this should probably be configurable so as not to require recompilation. For now, this kicks the can down the road while allowing this build matrix use case to exist.
    @colindean
    colindean committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1b95cf6 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Merge branch 'main' into bump-starlark-limit

    @colindean
    colindean authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    d2c5db6 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. refactor(db): return user on created and updated (#935)

    @ecrupper
    ecrupper committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    3547e2a View commit details
    Browse the repository at this point in the history

  2. enhance(starlark): make execution step limit configurable

    @ecrupper
    ecrupper committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    85a477d View commit details
    Browse the repository at this point in the history

  3. remove compose configuration

    @ecrupper
    ecrupper committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4d98328 View commit details
    Browse the repository at this point in the history

  4. make execlimit part of test struct

    @ecrupper
    ecrupper committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    20a9da6 View commit details
    Browse the repository at this point in the history

  5. update limit for Render

    @ecrupper
    ecrupper committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    df7a196 View commit details
    Browse the repository at this point in the history

  6. enhance: use consistent variable aliases (#946)

    @plyr4 @ecrupper
    plyr4 authored and ecrupper committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    294a893 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into enhance/configurable-starlark-exec-limit

    @ecrupper
    ecrupper authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    c588a46 View commit details
    Browse the repository at this point in the history

  8. remove helper function to get limit

    @ecrupper
    ecrupper committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b7ee3eb View commit details
    Browse the repository at this point in the history

  9. Merge branch 'enhance/configurable-starlark-exec-limit' of github.com… 

    …:go-vela/server into enhance/configurable-starlark-exec-limit
    @ecrupper
    ecrupper committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    afc99b7 View commit details
    Browse the repository at this point in the history