-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(repo sync): ignore inactive repos #953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
==========================================
+ Coverage 70.95% 70.97% +0.02%
==========================================
Files 312 312
Lines 12923 12922 -1
==========================================
+ Hits 9170 9172 +2
+ Misses 3287 3285 -2
+ Partials 466 465 -1
📢 Have feedback on the report? Share it here. |
ecrupper
requested changes
Sep 6, 2023
ecrupper
requested changes
Sep 7, 2023
wass3rw3rk
reviewed
Sep 7, 2023
ecrupper
previously approved these changes
Sep 7, 2023
wass3rw3rk
previously approved these changes
Sep 7, 2023
KellyMerrick
dismissed stale reviews from wass3rw3rk and ecrupper
via
September 7, 2023 19:14
fa99939
ecrupper
previously approved these changes
Sep 7, 2023
wass3r
previously approved these changes
Sep 7, 2023
wass3r
approved these changes
Sep 7, 2023
ecrupper
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes go-vela/community#852.
Add bool to track if webhook has been deleted from SCM:
server/scm/github/repo.go
Lines 263 to 274 in f89e929
And then update status to inactive in the database:
server/api/scm/sync_org.go
Lines 140 to 164 in f89e929