fix(compiler): return error on bad regular expressions that fail to compile in Purge #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claire1618
previously approved these changes
Oct 12, 2023
timhuynh94
previously approved these changes
Oct 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #985 +/- ##
==========================================
- Coverage 71.08% 71.03% -0.05%
==========================================
Files 312 312
Lines 13009 13018 +9
==========================================
Hits 9247 9247
- Misses 3297 3303 +6
- Partials 465 468 +3
|
wass3rw3rk
approved these changes
Oct 13, 2023
plyr4
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: go-vela/types#327
Ref: go-vela/community#435
Note: all the compiler pkg test changes for
AutoCancelis so the tests can pass. They match what is in this PR