Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing Nullify() DeployNumber statment to actually work #351

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

claire1618
Copy link
Contributor

Forgot to change Deploy to DeployNumber when adding DeployNumber field to Build, fixing that here

@claire1618 claire1618 requested a review from a team as a code owner February 1, 2024 19:25
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86cbe53) 96.64% compared to head (dd45186) 96.64%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          69       69           
  Lines        5298     5298           
=======================================
  Hits         5120     5120           
  Misses        106      106           
  Partials       72       72           
Files Coverage Δ
database/build.go 100.00% <100.00%> (ø)

@claire1618 claire1618 merged commit 867f2d1 into main Feb 1, 2024
11 checks passed
@claire1618 claire1618 deleted the fix/build/deployNumber branch February 1, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants