Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vela OIDC Provider #375

Merged
merged 4 commits into from
May 16, 2024
Merged

feat: Vela OIDC Provider #375

merged 4 commits into from
May 16, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 3, 2024

The majority of this code will be in the server, and there is a branch with the same name there that has the implementation if anyone is curious.

For types specifically, I don't think VELA_ID_TOKEN_REQUEST_TOKENs should be available in all steps. Users should be able to specifically invoke the injection of the token using something like:

version: "1"

steps:
  - name: request token
    image: alpine:latest
    id_request: write  # becomes a claim in token `request`
    commands:
      - apk add curl
      - 'curl -H "Authorization: Bearer $VELA_ID_TOKEN_REQUEST_TOKEN" $VELA_ID_TOKEN_REQUEST_URL'

The string value for id_request just becomes one of the claims in the eventual ID token. I figured that may be useful in some contexts.

@ecrupper ecrupper requested a review from a team as a code owner May 3, 2024 14:23
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (88010b5) to head (d009d65).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          69       69           
  Lines        5361     5363    +2     
=======================================
+ Hits         5151     5153    +2     
  Misses        136      136           
  Partials       74       74           
Files Coverage Δ
pipeline/container.go 80.95% <100.00%> (+0.13%) ⬆️
yaml/step.go 95.55% <100.00%> (+0.10%) ⬆️

@ecrupper ecrupper merged commit 57d6b8f into main May 16, 2024
11 checks passed
@ecrupper ecrupper deleted the feat/oidc-provider branch May 16, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants