fix(swagger): remove old model annotations #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the modified model annotations have moved to go-vela/server/api/types where a duplicate of these annotations can be found. this change is needed for accurate swagger doc generation. see go-vela/server#1159
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 69 69
Lines 5365 5365
=======================================
Hits 5155 5155
Misses 136 136
Partials 74 74
|
plyr4
approved these changes
Jul 26, 2024
timhuynh94
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the modified model annotations have moved to go-vela/server/api/types where a duplicate of these annotations can be found. this change is needed for accurate swagger doc generation. see
go-vela/server#1159 .
i've replaced the swagger documentation with godoc annotation that marks these structs as deprecated, so we should see warnings anywhere these are used yet.