Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(revert): use buildkite as yaml parser #392

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

Due to the breaking changes in v3 and the accelerated timeline of getting v0.25.0 out the door, our YAML library change will occur in v0.26

Additional context: #391

@ecrupper ecrupper self-assigned this Sep 26, 2024
@ecrupper ecrupper requested a review from a team as a code owner September 26, 2024 16:09
yaml/stage.go Show resolved Hide resolved
yaml/stage.go Show resolved Hide resolved
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (2d20d54) to head (0a4ae42).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   96.02%   96.05%   +0.03%     
==========================================
  Files          69       69              
  Lines        5382     5376       -6     
==========================================
- Hits         5168     5164       -4     
+ Misses        138      137       -1     
+ Partials       76       75       -1     
Files with missing lines Coverage Δ
library/string.go 100.00% <ø> (ø)
yaml/stage.go 100.00% <100.00%> (+3.57%) ⬆️

Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll kill you next time..... buildkite

@ecrupper ecrupper merged commit 15b43e5 into main Sep 26, 2024
9 of 11 checks passed
@ecrupper ecrupper deleted the revert/buildkite-again branch September 26, 2024 17:08
wass3rw3rk added a commit to go-vela/server that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants