Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate Deployment library type #394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

fix: deprecate Deployment library type

ac19959
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

fix: deprecate Deployment library type #394

fix: deprecate Deployment library type
ac19959
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci failed Oct 2, 2024 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (30)

pipeline/ruleset.go|134 col 1| cyclomatic complexity 31 of func (*Rules).Match is high (> 30) (gocyclo)
database/build.go|364 col 44| G115: integer overflow conversion int -> int32 (gosec)
database/build.go|365 col 44| G115: integer overflow conversion int -> int32 (gosec)
database/hook.go|200 col 42| G115: integer overflow conversion int -> int32 (gosec)
item.go|17 col 9| SA1019: library.Build is deprecated: use Build from github.com/go-vela/server/api/types instead. (staticcheck)
item.go|18 col 9| SA1019: library.Repo is deprecated: use Repo from github.com/go-vela/server/api/types instead. (staticcheck)
item.go|19 col 9| SA1019: library.User is deprecated: use User from github.com/go-vela/server/api/types instead. (staticcheck)
item.go|25 col 16| SA1019: library.Build is deprecated: use Build from github.com/go-vela/server/api/types instead. (staticcheck)
webhook.go|29 col 15| SA1019: library.Hook is deprecated: use Hook from github.com/go-vela/server/api/types instead. (staticcheck)
webhook.go|30 col 15| SA1019: library.Repo is deprecated: use Repo from github.com/go-vela/server/api/types instead. (staticcheck)
webhook.go|31 col 15| SA1019: library.Build is deprecated: use Build from github.com/go-vela/server/api/types instead. (staticcheck)
webhook.go|33 col 15| SA1019: library.Deployment is deprecated: use Deployment from github.com/go-vela/server/api/types instead. (staticcheck)
item_test.go|44 col 8| SA1019: library.Repo is deprecated: use Repo from github.com/go-vela/server/api/types instead. (staticcheck)
item_test.go|60 col 8| SA1019: library.User is deprecated: use User from github.com/go-vela/server/api/types instead. (staticcheck)
item_test.go|108 col 10| SA1019: library.User is deprecated: use User from github.com/go-vela/server/api/types instead. (staticcheck)
database/build_queue.go|21 col 35| SA1019: library.BuildQueue is deprecated: use QueueBuild from github.com/go-vela/server/api/types instead. (staticcheck)
database/build_queue.go|22 col 20| SA1019: library.BuildQueue is deprecated: use QueueBuild from github.com/go-vela/server/api/types instead. (staticcheck)
database/build_queue.go|34 col 31| SA1019: library.BuildQueue is deprecated: use QueueBuild from github.com/go-vela/server/api/types instead. (staticcheck)
database/deployment.go|116 col 20| SA1019: library.Deployment is deprecated: use Deployment from github.com/go-vela/server/api/types instead. (staticcheck)
database/deployment.go|178 col 31| SA1019: library.Deployment is deprecated: use Deployment from github.com/go-vela/server/api/types instead. (staticcheck)
database/hook.go|134 col 29| SA1019: library.Hook is deprecated: use Hook from github.com/go-vela/server/api/types instead. (staticcheck)
database/hook.go|135 col 14| SA1019: library.Hook is deprecated: use Hook from github.com/go-vela/server/api/types instead. (staticcheck)
database/schedule.go|44 col 29| SA1019: library.Schedule is deprecated: use Schedule from github.com/go-vela/server/api/types instead. (staticcheck)
database/schedule.go|98 col 33| SA1019: library.Schedule is deprecated: use Schedule from github.com/go-vela/server/api/types instead. (staticcheck)
database/schedule.go|99 col 10| SA1019: library.Schedule is deprecated: use Schedule from github.com/go-vela/server/api/types instead. (staticcheck)
database/worker.go|105 col 31| SA1019: library.Worker is deprecated: use Worker from github.com/go-vela/server/api/types instead. (staticcheck)
database/worker.go|106 col 16| SA1019: library.Worker is deprecated: use Worker from github.com/go-vela/server/api/types instead. (staticcheck)
database/worker.go|167 col 27| SA1019: library.Worker is deprecated: use Worker from github.com/go-vela/server/api/types instead. (staticcheck)
yaml/stage.go|91 col 5| return statements should not be cuddled if block has more than two lines (wsl)
yaml/stage.go|97 col 2| return statements should not be cuddled if block has more than two lines (wsl)

Filtered Findings (0)

Annotations

Check failure on line 134 in pipeline/ruleset.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pipeline/ruleset.go#L134

cyclomatic complexity 31 of func `(*Rules).Match` is high (> 30) (gocyclo)
Raw output
pipeline/ruleset.go:134:1: cyclomatic complexity 31 of func `(*Rules).Match` is high (> 30) (gocyclo)
func (r *Rules) Match(from *RuleData, matcher, op string) (bool, error) {
^

Check failure on line 364 in database/build.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/build.go#L364

G115: integer overflow conversion int -> int32 (gosec)
Raw output
database/build.go:364:44: G115: integer overflow conversion int -> int32 (gosec)
		Number:        sql.NullInt32{Int32: int32(b.GetNumber()), Valid: true},
		                                         ^

Check failure on line 365 in database/build.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/build.go#L365

G115: integer overflow conversion int -> int32 (gosec)
Raw output
database/build.go:365:44: G115: integer overflow conversion int -> int32 (gosec)
		Parent:        sql.NullInt32{Int32: int32(b.GetParent()), Valid: true},
		                                         ^

Check failure on line 200 in database/hook.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/hook.go#L200

G115: integer overflow conversion int -> int32 (gosec)
Raw output
database/hook.go:200:42: G115: integer overflow conversion int -> int32 (gosec)
		Number:      sql.NullInt32{Int32: int32(h.GetNumber()), Valid: true},
		                                       ^

Check failure on line 17 in item.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] item.go#L17

SA1019: library.Build is deprecated: use Build from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
item.go:17:9: SA1019: library.Build is deprecated: use Build from github.com/go-vela/server/api/types instead. (staticcheck)
	Build *library.Build `json:"build"`
	       ^

Check failure on line 18 in item.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] item.go#L18

SA1019: library.Repo is deprecated: use Repo from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
item.go:18:9: SA1019: library.Repo is deprecated: use Repo from github.com/go-vela/server/api/types instead. (staticcheck)
	Repo  *library.Repo  `json:"repo"`
	       ^

Check failure on line 19 in item.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] item.go#L19

SA1019: library.User is deprecated: use User from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
item.go:19:9: SA1019: library.User is deprecated: use User from github.com/go-vela/server/api/types instead. (staticcheck)
	User  *library.User  `json:"user"`
	       ^

Check failure on line 25 in item.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] item.go#L25

SA1019: library.Build is deprecated: use Build from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
item.go:25:16: SA1019: library.Build is deprecated: use Build from github.com/go-vela/server/api/types instead. (staticcheck)
func ToItem(b *library.Build, r *library.Repo, u *library.User) *Item {
               ^

Check failure on line 29 in webhook.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] webhook.go#L29

SA1019: library.Hook is deprecated: use Hook from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
webhook.go:29:15: SA1019: library.Hook is deprecated: use Hook from github.com/go-vela/server/api/types instead. (staticcheck)
	Hook        *library.Hook
	             ^

Check failure on line 30 in webhook.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] webhook.go#L30

SA1019: library.Repo is deprecated: use Repo from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
webhook.go:30:15: SA1019: library.Repo is deprecated: use Repo from github.com/go-vela/server/api/types instead. (staticcheck)
	Repo        *library.Repo
	             ^

Check failure on line 31 in webhook.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] webhook.go#L31

SA1019: library.Build is deprecated: use Build from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
webhook.go:31:15: SA1019: library.Build is deprecated: use Build from github.com/go-vela/server/api/types instead. (staticcheck)
	Build       *library.Build
	             ^

Check failure on line 33 in webhook.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] webhook.go#L33

SA1019: library.Deployment is deprecated: use Deployment from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
webhook.go:33:15: SA1019: library.Deployment is deprecated: use Deployment from github.com/go-vela/server/api/types instead. (staticcheck)
	Deployment  *library.Deployment
	             ^

Check failure on line 44 in item_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] item_test.go#L44

SA1019: library.Repo is deprecated: use Repo from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
item_test.go:44:8: SA1019: library.Repo is deprecated: use Repo from github.com/go-vela/server/api/types instead. (staticcheck)
	r := &library.Repo{
	      ^

Check failure on line 60 in item_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] item_test.go#L60

SA1019: library.User is deprecated: use User from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
item_test.go:60:8: SA1019: library.User is deprecated: use User from github.com/go-vela/server/api/types instead. (staticcheck)
	u := &library.User{
	      ^

Check failure on line 108 in item_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] item_test.go#L108

SA1019: library.User is deprecated: use User from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
item_test.go:108:10: SA1019: library.User is deprecated: use User from github.com/go-vela/server/api/types instead. (staticcheck)
		User: &library.User{
		       ^

Check failure on line 21 in database/build_queue.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/build_queue.go#L21

SA1019: library.BuildQueue is deprecated: use QueueBuild from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/build_queue.go:21:35: SA1019: library.BuildQueue is deprecated: use QueueBuild from github.com/go-vela/server/api/types instead. (staticcheck)
func (b *BuildQueue) ToLibrary() *library.BuildQueue {
                                  ^

Check failure on line 22 in database/build_queue.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/build_queue.go#L22

SA1019: library.BuildQueue is deprecated: use QueueBuild from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/build_queue.go:22:20: SA1019: library.BuildQueue is deprecated: use QueueBuild from github.com/go-vela/server/api/types instead. (staticcheck)
	buildQueue := new(library.BuildQueue)
	                  ^

Check failure on line 34 in database/build_queue.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/build_queue.go#L34

SA1019: library.BuildQueue is deprecated: use QueueBuild from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/build_queue.go:34:31: SA1019: library.BuildQueue is deprecated: use QueueBuild from github.com/go-vela/server/api/types instead. (staticcheck)
func BuildQueueFromLibrary(b *library.BuildQueue) *BuildQueue {
                              ^

Check failure on line 116 in database/deployment.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/deployment.go#L116

SA1019: library.Deployment is deprecated: use Deployment from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/deployment.go:116:20: SA1019: library.Deployment is deprecated: use Deployment from github.com/go-vela/server/api/types instead. (staticcheck)
	deployment := new(library.Deployment)
	                  ^

Check failure on line 178 in database/deployment.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/deployment.go#L178

SA1019: library.Deployment is deprecated: use Deployment from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/deployment.go:178:31: SA1019: library.Deployment is deprecated: use Deployment from github.com/go-vela/server/api/types instead. (staticcheck)
func DeploymentFromLibrary(d *library.Deployment) *Deployment {
                              ^

Check failure on line 134 in database/hook.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/hook.go#L134

SA1019: library.Hook is deprecated: use Hook from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/hook.go:134:29: SA1019: library.Hook is deprecated: use Hook from github.com/go-vela/server/api/types instead. (staticcheck)
func (h *Hook) ToLibrary() *library.Hook {
                            ^

Check failure on line 135 in database/hook.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/hook.go#L135

SA1019: library.Hook is deprecated: use Hook from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/hook.go:135:14: SA1019: library.Hook is deprecated: use Hook from github.com/go-vela/server/api/types instead. (staticcheck)
	hook := new(library.Hook)
	            ^

Check failure on line 44 in database/schedule.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/schedule.go#L44

SA1019: library.Schedule is deprecated: use Schedule from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/schedule.go:44:29: SA1019: library.Schedule is deprecated: use Schedule from github.com/go-vela/server/api/types instead. (staticcheck)
func ScheduleFromLibrary(s *library.Schedule) *Schedule {
                            ^

Check failure on line 98 in database/schedule.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/schedule.go#L98

SA1019: library.Schedule is deprecated: use Schedule from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/schedule.go:98:33: SA1019: library.Schedule is deprecated: use Schedule from github.com/go-vela/server/api/types instead. (staticcheck)
func (s *Schedule) ToLibrary() *library.Schedule {
                                ^

Check failure on line 99 in database/schedule.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/schedule.go#L99

SA1019: library.Schedule is deprecated: use Schedule from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
database/schedule.go:99:10: SA1019: library.Schedule is deprecated: use Schedule from github.com/go-vela/server/api/types instead. (staticcheck)
	return &library.Schedule{
	        ^