Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update alpine #64

Merged
merged 3 commits into from
Apr 11, 2024

update workflow

cc8f019
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore: update alpine #64

update workflow
cc8f019
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci failed Apr 10, 2024 in 5s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (7)

pkg/binarywrapper/binarywrapper.go|180 col 13| G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)
pkg/binarywrapper/binarywrapper.go|184 col 4| return statements should not be cuddled if block has more than two lines (wsl)
internal/scp/scp_test.go|158 col 5| expressions should not be cuddled with blocks (wsl)
internal/scp/scp_test.go|166 col 5| expressions should not be cuddled with blocks (wsl)
internal/ssh/ssh_test.go|166 col 5| expressions should not be cuddled with blocks (wsl)
pkg/binarywrapper/binarywrapper_test.go|156 col 4| expressions should not be cuddled with declarations or returns (wsl)
pkg/binarywrapper/binarywrapper_test.go|264 col 4| expressions should not be cuddled with declarations or returns (wsl)

Filtered Findings (0)

Annotations

Check failure on line 180 in pkg/binarywrapper/binarywrapper.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/binarywrapper/binarywrapper.go#L180 

G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)
Raw output 
pkg/binarywrapper/binarywrapper.go:180:13: G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)
		if err := syscall.Exec(p.Binary(), expandedArgs, os.Environ()); err != nil {
		          ^

Check failure on line 184 in pkg/binarywrapper/binarywrapper.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/binarywrapper/binarywrapper.go#L184 

return statements should not be cuddled if block has more than two lines (wsl)
Raw output 
pkg/binarywrapper/binarywrapper.go:184:4: return statements should not be cuddled if block has more than two lines (wsl)
			return fmt.Errorf("%w: %w", ErrExec, err)
			^

Check failure on line 158 in internal/scp/scp_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/scp/scp_test.go#L158 

expressions should not be cuddled with blocks (wsl)
Raw output 
internal/scp/scp_test.go:158:5: expressions should not be cuddled with blocks (wsl)
				testutils.ValidateMockFile(t, test.mockFS, test.config.locationPasswordFile, test.config.SSHPassword)
				^

Check failure on line 166 in internal/scp/scp_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/scp/scp_test.go#L166 

expressions should not be cuddled with blocks (wsl)
Raw output 
internal/scp/scp_test.go:166:5: expressions should not be cuddled with blocks (wsl)
				testutils.ValidateMockFile(t, test.mockFS, test.config.locationPassphraseFile, test.config.SSHPassphrase)
				^

Check failure on line 166 in internal/ssh/ssh_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/ssh/ssh_test.go#L166 

expressions should not be cuddled with blocks (wsl)
Raw output 
internal/ssh/ssh_test.go:166:5: expressions should not be cuddled with blocks (wsl)
				testutils.ValidateMockFile(t, test.mockFS, test.config.locationPassphraseFile, test.config.SSHPassphrase)
				^

Check failure on line 156 in pkg/binarywrapper/binarywrapper_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/binarywrapper/binarywrapper_test.go#L156 

expressions should not be cuddled with declarations or returns (wsl)
Raw output 
pkg/binarywrapper/binarywrapper_test.go:156:4: expressions should not be cuddled with declarations or returns (wsl)
			logrus.SetOutput(&outputBuffer)
			^

Check failure on line 264 in pkg/binarywrapper/binarywrapper_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/binarywrapper/binarywrapper_test.go#L264 

expressions should not be cuddled with declarations or returns (wsl)
Raw output 
pkg/binarywrapper/binarywrapper_test.go:264:4: expressions should not be cuddled with declarations or returns (wsl)
			logrus.SetOutput(&outputBuffer)
			^
View more details on GitHub Actions