Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remote slack attachment #56

Merged
merged 12 commits into from
Nov 28, 2023
Merged

Conversation

claire1618
Copy link
Contributor

These changes allows to Slack could source a message file from another repo.

This will help is someone has to send a message held in one repo across multiple repos.

Below is an example for the new parameters introduced (remote, registry):

parameters:
    filepath: $remote-filepath
    remote: true
    registry: https://github.com

cmd/vela-slack/plugin_test.go Outdated Show resolved Hide resolved
cmd/vela-slack/plugin_test.go Outdated Show resolved Hide resolved
cmd/vela-slack/plugin_test.go Outdated Show resolved Hide resolved
cmd/vela-slack/plugin.go Outdated Show resolved Hide resolved
cmd/vela-slack/plugin.go Show resolved Hide resolved
cmd/vela-slack/plugin.go Show resolved Hide resolved
cmd/vela-slack/plugin.go Show resolved Hide resolved
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #56 (03874b5) into main (1213574) will increase coverage by 4.76%.
The diff coverage is 68.96%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   17.94%   22.70%   +4.76%     
==========================================
  Files           2        2              
  Lines         574      643      +69     
==========================================
+ Hits          103      146      +43     
- Misses        463      488      +25     
- Partials        8        9       +1     
Files Coverage Δ
cmd/vela-slack/plugin.go 84.39% <95.23%> (+3.29%) ⬆️
cmd/vela-slack/main.go 0.00% <0.00%> (ø)

@claire1618 claire1618 marked this pull request as ready for review November 27, 2023 16:53
@claire1618 claire1618 requested a review from a team as a code owner November 27, 2023 16:53
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably fix the couple of linter errors in main.go. we got rid of io/ioutil elsewhere for example, we can use the correct module in main.

Claire.Nicholas and others added 2 commits November 27, 2023 11:07
cmd/vela-slack/main.go Outdated Show resolved Hide resolved
Claire.Nicholas added 2 commits November 27, 2023 11:31
@ecrupper
Copy link
Contributor

Can we get these updates to DOCS.md since we pull those in for our doc site? Maybe in a separate PR so it isn't updated prematurely?

Claire.Nicholas added 2 commits November 28, 2023 09:48
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@claire1618 claire1618 merged commit ae5cb77 into main Nov 28, 2023
10 of 12 checks passed
@claire1618 claire1618 deleted the enhance/remoteSlackAttachment branch November 28, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants