-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: remote slack attachment #56
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 17.94% 22.70% +4.76%
==========================================
Files 2 2
Lines 574 643 +69
==========================================
+ Hits 103 146 +43
- Misses 463 488 +25
- Partials 8 9 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably fix the couple of linter errors in main.go. we got rid of io/ioutil elsewhere for example, we can use the correct module in main.
Can we get these updates to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat
These changes allows to Slack could source a message file from another repo.
This will help is someone has to send a message held in one repo across multiple repos.
Below is an example for the new parameters introduced (remote, registry):