Skip to content
test

chore(deps): update all non-major dependencies #706

Sign in to view logs

chore(deps): update all non-major dependencies

chore(deps): update all non-major dependencies #706

GitHub Actions / golangci failed Sep 25, 2024 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (10)

cmd/vela-slack/plugin_test.go|67 col 72| unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
cmd/vela-slack/plugin_test.go|90 col 72| unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
cmd/vela-slack/plugin_test.go|113 col 72| unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
cmd/vela-slack/main.go|486 col 12| SA1019: ldap.DialTLS is deprecated: Use DialURL instead. (staticcheck)
cmd/vela-slack/plugin_test.go|115 col 3| assignments should only be cuddled with other assignments (wsl)
cmd/vela-slack/plugin_test.go|175 col 3| only one cuddle assignment allowed before if statement (wsl)
cmd/vela-slack/plugin_test.go|178 col 3| assignments should only be cuddled with other assignments (wsl)
cmd/vela-slack/plugin_test.go|251 col 3| assignments should only be cuddled with other assignments (wsl)
cmd/vela-slack/plugin_test.go|252 col 3| only one cuddle assignment allowed before if statement (wsl)
cmd/vela-slack/plugin_test.go|116 col 3| only one cuddle assignment allowed before if statement (wsl)

Filtered Findings (0)

Annotations

Check failure on line 67 in cmd/vela-slack/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/plugin_test.go#L67 

unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
Raw output 
cmd/vela-slack/plugin_test.go:67:72: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
	                                                                      ^

Check failure on line 90 in cmd/vela-slack/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/plugin_test.go#L90 

unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
Raw output 
cmd/vela-slack/plugin_test.go:90:72: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
	                                                                      ^

Check failure on line 113 in cmd/vela-slack/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/plugin_test.go#L113 

unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
Raw output 
cmd/vela-slack/plugin_test.go:113:72: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
	ta := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
	                                                                      ^

Check failure on line 486 in cmd/vela-slack/main.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/main.go#L486 

SA1019: ldap.DialTLS is deprecated:  Use DialURL instead. (staticcheck)
Raw output 
cmd/vela-slack/main.go:486:12: SA1019: ldap.DialTLS is deprecated:  Use DialURL instead. (staticcheck)
	l, err := ldap.DialTLS("tcp", fmt.Sprintf("%s:%s", ldapServer, ldapPort), config)
	          ^

Check failure on line 115 in cmd/vela-slack/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/plugin_test.go#L115 

assignments should only be cuddled with other assignments (wsl)
Raw output 
cmd/vela-slack/plugin_test.go:115:3: assignments should only be cuddled with other assignments (wsl)
		bytes, err := os.ReadFile("./testdata/slack_attachment_remote.json")
		^

Check failure on line 175 in cmd/vela-slack/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/plugin_test.go#L175 

only one cuddle assignment allowed before if statement (wsl)
Raw output 
cmd/vela-slack/plugin_test.go:175:3: only one cuddle assignment allowed before if statement (wsl)
		if err != nil {
		^

Check failure on line 178 in cmd/vela-slack/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/plugin_test.go#L178 

assignments should only be cuddled with other assignments (wsl)
Raw output 
cmd/vela-slack/plugin_test.go:178:3: assignments should only be cuddled with other assignments (wsl)
		_, err = w.Write(bytes)
		^

Check failure on line 251 in cmd/vela-slack/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/plugin_test.go#L251 

assignments should only be cuddled with other assignments (wsl)
Raw output 
cmd/vela-slack/plugin_test.go:251:3: assignments should only be cuddled with other assignments (wsl)
		bytes, err := os.ReadFile("./testdata/slack_attachment_remote_bad.json")
		^

Check failure on line 252 in cmd/vela-slack/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/plugin_test.go#L252 

only one cuddle assignment allowed before if statement (wsl)
Raw output 
cmd/vela-slack/plugin_test.go:252:3: only one cuddle assignment allowed before if statement (wsl)
		if err != nil {
		^

Check failure on line 116 in cmd/vela-slack/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-slack/plugin_test.go#L116 

only one cuddle assignment allowed before if statement (wsl)
Raw output 
cmd/vela-slack/plugin_test.go:116:3: only one cuddle assignment allowed before if statement (wsl)
		if err != nil {
		^
View more details on GitHub Actions