Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq4: extend ZMTP greeting tests for various version cases #61

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented Jan 20, 2020

Updates #56.

@codecov-io
Copy link

codecov-io commented Jan 20, 2020

Codecov Report

Merging #61 into master will decrease coverage by 0.02%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   54.94%   54.92%   -0.03%     
==========================================
  Files          26       26              
  Lines        1931     1941      +10     
==========================================
+ Hits         1061     1066       +5     
- Misses        778      782       +4     
- Partials       92       93       +1
Impacted Files Coverage Δ
protocol.go 77.23% <81.81%> (+0.24%) ⬆️
conn.go 54.73% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411132b...6eb16eb. Read the comment docs.

@sbinet sbinet merged commit 6eb16eb into go-zeromq:master Jan 20, 2020
@sbinet sbinet deleted the issue-56 branch January 20, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants