Skip to content

Commit

Permalink
Show warning before deleting plugin data (#1474)
Browse files Browse the repository at this point in the history
  • Loading branch information
@foophoof
foophoof authored Oct 6, 2023
1 parent 5cc7d4e commit 9fe5ca3
Showing 1 changed file with 105 additions and 22 deletions.
127 changes: 105 additions & 22 deletions Dalamud/Interface/Internal/Windows/PluginInstaller/PluginInstallerWindow.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ internal class PluginInstallerWindow : Window, IDisposable
private bool testingWarningModalDrawing = true;
private bool testingWarningModalOnNextFrame = false;

private bool deletePluginConfigWarningModalDrawing = true;
private bool deletePluginConfigWarningModalOnNextFrame = false;
private string deletePluginConfigWarningModalPluginName = string.Empty;
private TaskCompletionSource<bool>? deletePluginConfigWarningModalTaskCompletionSource;

private bool feedbackModalDrawing = true;
private bool feedbackModalOnNextFrame = false;
private bool feedbackModalOnNextFrameDontClear = false;
Expand Down Expand Up @@ -259,6 +264,7 @@ public override void Draw()
this.DrawErrorModal();
this.DrawUpdateModal();
this.DrawTestingWarningModal();
this.DrawDeletePluginConfigWarningModal();
this.DrawFeedbackModal();
this.DrawProgressOverlay();
}
Expand Down Expand Up @@ -825,6 +831,55 @@ private void DrawTestingWarningModal()
}
}

private Task<bool> ShowDeletePluginConfigWarningModal(string pluginName)
{
this.deletePluginConfigWarningModalOnNextFrame = true;
this.deletePluginConfigWarningModalPluginName = pluginName;
this.deletePluginConfigWarningModalTaskCompletionSource = new TaskCompletionSource<bool>();
return this.deletePluginConfigWarningModalTaskCompletionSource.Task;
}

private void DrawDeletePluginConfigWarningModal()
{
var modalTitle = Locs.DeletePluginConfigWarningModal_Title;

if (ImGui.BeginPopupModal(modalTitle, ref this.deletePluginConfigWarningModalDrawing, ImGuiWindowFlags.AlwaysAutoResize | ImGuiWindowFlags.NoScrollbar))
{
ImGui.Text(Locs.DeletePluginConfigWarningModal_Body(this.deletePluginConfigWarningModalPluginName));
ImGui.Spacing();

var buttonWidth = 120f;
ImGui.SetCursorPosX((ImGui.GetWindowWidth() - ((buttonWidth * 2) - (ImGui.GetStyle().ItemSpacing.Y * 2))) / 2);

if (ImGui.Button(Locs.DeletePluginConfirmWarningModal_Yes, new Vector2(buttonWidth, 40)))
{
ImGui.CloseCurrentPopup();
this.deletePluginConfigWarningModalTaskCompletionSource?.SetResult(true);
}

ImGui.SameLine();

if (ImGui.Button(Locs.DeletePluginConfirmWarningModal_No, new Vector2(buttonWidth, 40)))
{
ImGui.CloseCurrentPopup();
this.deletePluginConfigWarningModalTaskCompletionSource?.SetResult(false);
}

ImGui.EndPopup();
}

if (this.deletePluginConfigWarningModalOnNextFrame)
{
// NOTE(goat): ImGui cannot open a modal if no window is focused, at the moment.
// If people click out of the installer into the game while a plugin is installing, we won't be able to show a modal if we don't grab focus.
ImGui.SetWindowFocus(this.WindowName);

ImGui.OpenPopup(modalTitle);
this.deletePluginConfigWarningModalOnNextFrame = false;
this.deletePluginConfigWarningModalDrawing = true;
}
}

private void DrawFeedbackModal()
{
var modalTitle = Locs.FeedbackModal_Title;
Expand Down Expand Up @@ -2044,24 +2099,32 @@ private void DrawAvailablePluginContextMenu(PluginManifest manifest)

if (ImGui.Selectable(Locs.PluginContext_DeletePluginConfig))
{
Log.Debug($"Deleting config for {manifest.InternalName}");

this.installStatus = OperationStatus.InProgress;
this.ShowDeletePluginConfigWarningModal(manifest.Name).ContinueWith(t =>
{
var shouldDelete = t.Result;

Task.Run(() =>
if (shouldDelete)
{
pluginManager.PluginConfigs.Delete(manifest.InternalName);
var dir = pluginManager.PluginConfigs.GetDirectory(manifest.InternalName);
Log.Debug($"Deleting config for {manifest.InternalName}");

if (Directory.Exists(dir))
Directory.Delete(dir, true);
})
.ContinueWith(task =>
{
this.installStatus = OperationStatus.Idle;
this.installStatus = OperationStatus.InProgress;

this.DisplayErrorContinuation(task, Locs.ErrorModal_DeleteConfigFail(manifest.InternalName));
});
Task.Run(() =>
{
pluginManager.PluginConfigs.Delete(manifest.InternalName);
var dir = pluginManager.PluginConfigs.GetDirectory(manifest.InternalName);

if (Directory.Exists(dir))
Directory.Delete(dir, true);
})
.ContinueWith(task =>
{
this.installStatus = OperationStatus.Idle;

this.DisplayErrorContinuation(task, Locs.ErrorModal_DeleteConfigFail(manifest.InternalName));
});
}
});
}

ImGui.EndPopup();
Expand Down Expand Up @@ -2384,17 +2447,25 @@ private void DrawInstalledPluginContextMenu(LocalPlugin plugin, PluginTestingOpt

if (ImGui.MenuItem(Locs.PluginContext_DeletePluginConfigReload))
{
Log.Debug($"Deleting config for {plugin.Manifest.InternalName}");

this.installStatus = OperationStatus.InProgress;
this.ShowDeletePluginConfigWarningModal(plugin.Name).ContinueWith(t =>
{
var shouldDelete = t.Result;

Task.Run(() => pluginManager.DeleteConfigurationAsync(plugin))
.ContinueWith(task =>
if (shouldDelete)
{
this.installStatus = OperationStatus.Idle;
Log.Debug($"Deleting config for {plugin.Manifest.InternalName}");

this.DisplayErrorContinuation(task, Locs.ErrorModal_DeleteConfigFail(plugin.Name));
});
this.installStatus = OperationStatus.InProgress;

Task.Run(() => pluginManager.DeleteConfigurationAsync(plugin))
.ContinueWith(task =>
{
this.installStatus = OperationStatus.Idle;

this.DisplayErrorContinuation(task, Locs.ErrorModal_DeleteConfigFail(plugin.Name));
});
}
});
}

ImGui.EndPopup();
Expand Down Expand Up @@ -3578,6 +3649,18 @@ public static string PluginBody_BannedReason(string message) =>

#endregion

#region Delete Plugin Config Warning Modal

public static string DeletePluginConfigWarningModal_Title => Loc.Localize("InstallerDeletePluginConfigWarning", "Warning###InstallerDeletePluginConfigWarning");

public static string DeletePluginConfigWarningModal_Body(string pluginName) => Loc.Localize("InstallerDeletePluginConfigWarningBody", "Are you sure you want to delete all data and configuration for v{0}?").Format(pluginName);

public static string DeletePluginConfirmWarningModal_Yes => Loc.Localize("InstallerDeletePluginConfigWarningYes", "Yes");

public static string DeletePluginConfirmWarningModal_No => Loc.Localize("InstallerDeletePluginConfigWarningNo", "No");

#endregion

#region Plugin Update chatbox

public static string PluginUpdateHeader_Chatbox => Loc.Localize("DalamudPluginUpdates", "Updates:");
Expand Down

0 comments on commit 9fe5ca3

Please sign in to comment.