Fix ImGui keyboard event not being handled correctly #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polling `KeyState` buffer and writing zeros as needed was common method to implement hotkey feature. This, however, can cause certain actions like running being abruptly interrupted or misbehaving (processing as if it was pressed again despite the user never released it) due to the nature of key state buffer. This commit introduces `SimulatedKeyState` and `KeyCapture` services. `SimulatedKeyStates` roughly simulates how the game calculates key states and `KeyCapture` uses their own rules to decide when to pass this value as inputs to the game.
This is a last minute change. I believe there's no harm in exposing this service to plugins, but who knows...
Minoost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue where
io->WantCaptureKeyboardorImGui.IsKeyPresseddoes nothing unlessio.WantTextInputis also set.Changes in ImGuiScene are also needed. For that, please check out this PR.
Clips
o.mp4
(Notice
WantCaptureKeyboarddoes nothing)f1.mp4
p1.mp4
f2.mp4