-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CJK IMEs work better #1564
Conversation
@Bluefissure would you mind testing this PR with a Chinese IME? |
Sure, I have a bunch of meetings this evening so probably I need to test after the meetings. |
I tested these changes against the Japanese issues listed in #1498 and it seems to fix both of them (simultaneous input problem, and the "stuck in alphabetic mode" problem). There is still a small issue where, if there is an active input (i.e. blinking cursor) in a native game input, and we switch to an imgui input, then both completion windows will appear as text is typed since both inputs are kind of simultaneously active (and if there is a completion active already when focus is changed, those completion options will also carry over to the imgui input completion). This only happens one-way as switching to a native game input will clear imgui focus, but not vice-versa. However, selecting a completion will only add it to the actually active input, so I think this is a very minor issue and not worth holding back these changes. |
It's working fine in Microsoft Pinyin (Chinese IME) as: It also fixes ottercorp#39 |
@Bluefissure Now that you're testing it, can you test if Latin character input mode displays its corresponding symbol "英"? Since Japanese IME had different condition for that compared to Korean, need to check if Chinese IME works like Korean IME or Japanese IME. |
|
Sounds good enough then! |
93ea937
to
f732b13
Compare
Changes
Someone should test Chinese IMEs. This probably should work because Chromium had the least amount of special-casing for Chinese IME among CJK IME handling code, but better make sure.