-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build adjustments for code annotation #2155
base: master
Are you sure you want to change the base?
Conversation
7b82c94
to
95d7f9a
Compare
95d7f9a
to
ad133d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Actions sets an environment variable (CI
) to true
. please only ensure these changes are only active when CI == true
.
…to ci_annotate
…to ci_annotate
…mbined build/test step.
Well...git's quite something and re-commited a bunch of things despite my best efforts - anyway: It now checks for the CI variable before doing any changes to the logging, so local builds will function as normal. I also added |
Maybe have skip test being the default on non CI builds? |
Also an option, yeah. Then you could invoke it manually which would make sense since you're already having to do that with the current process. I can make that change if that's the way to go. |
The other side is to have a |
From my research, the |
… Tests can also be manually triggered with `test`.
Okay. I scratched the skip-tests thing entirely. Now, the build process runs |
This PR overrides Nuke's log handling and removes the problematic formatting the default analyzers were unable to process as well as improving the build flow to reduce duplicate warnings (and thus annotations). Building and testing have merged into a single step, and warnings are suppressed from the test rebuild since they're just refired from the initial build process anyway.
In addition, I adjusted the workflow so pushes to an existing pull request won't trigger both the push and PR builds to occur in some cases which also contributed to the warning duplication. In the end, file changes now have code-level annotations!