Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] SimpleMarketBoard 1.2.0.2 #3194

Merged
merged 3 commits into from
Feb 17, 2024
Merged

[Testing] SimpleMarketBoard 1.2.0.2 #3194

merged 3 commits into from
Feb 17, 2024

Conversation

Elypha
Copy link
Contributor

@Elypha Elypha commented Feb 15, 2024

Helllo,

In this PR:

  • a minor version update that resolves a new warning since the last dalamud update.
  • copy manifest to main

In the testing so far the plugin seems to be fine, so I think it might be time to release it under main. I'm not sure if I'm doing this properly so please let me know if there's anything I can improve.

@bleatbot bleatbot enabled auto-merge (squash) February 15, 2024 15:16
@bleatbot
Copy link
Collaborator

bleatbot commented Feb 15, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 17 hours.

Name Commit Status
✔️ SimpleMarketBoard [stable] b3ad109 v1.2.0.2 - Repo (New plugin)
😰 SimpleMarketBoard [testing-live] b3ad109 Build system error: Directory not empty : '/home/runner/work/DalamudPluginsD17/DalamudPluginsD17/work/SimpleMarketBoard-b3ad1092babf584bbe6ef2f81ed60e774da6d4a2-work'
Show log - Review

@bleatbot bleatbot added build failed This plugin failed to build. move channel This plugin is being moved to another channel. size-large Diff for this PR is large. labels Feb 15, 2024
@Elypha
Copy link
Contributor Author

Elypha commented Feb 15, 2024

hmmm for the compiling issue, am I not supposed to use the same hash for stable and testing/live?

@philpax
Copy link
Contributor

philpax commented Feb 15, 2024

Ah, that's a recently introduced issue. @goaaats is fixing it and should have this sorted out for you soon.

auto-merge was automatically disabled February 16, 2024 13:24

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ SimpleMarketBoard [stable] b3ad109 v1.2.0.2 - Repo (New plugin)
✔️ SimpleMarketBoard [testing-live] a680583 v1.2.0.3 - Diff (43 lines, prev. 1.2.0.1)
Show log - Review

@bleatbot bleatbot removed the build failed This plugin failed to build. label Feb 16, 2024
@Elypha
Copy link
Contributor Author

Elypha commented Feb 16, 2024

testing version advanced 1 for the sake of the compiler xx

@philpax philpax requested a review from goaaats February 16, 2024 15:11
@philpax philpax enabled auto-merge (squash) February 17, 2024 19:32
Copy link
Contributor

@philpax philpax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goat wasn't able to make time to fix the issue, so I'll just merge your version bump. Thanks for doing that - I'll make an issue for it so that it can be fixed at some later stage!

@philpax philpax merged commit 1e51d85 into goatcorp:main Feb 17, 2024
2 checks passed
@Elypha Elypha deleted the 1202 branch June 10, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
move channel This plugin is being moved to another channel. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants