-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord.RichPresence 2.0.5.0 #4663
Conversation
Now includes a setting to automatically run a Wine IPC Bridge for Linux users (if you need one). XIV On Mac users should continue to use the Wine IPC Bridge available in the XOM program settings. This change has no effect for Windows users of the plugin.
Outdated attemptBuilds failed, please check action output. Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it! The average merge time for plugin updates is currently 10 hours.
14 Needs (
|
Type | Name | Version | Reviewed by |
---|---|---|---|
NuGet | DiscordRichPresence | 1.2.1.24 | |
NuGet | Microsoft.NETCore.Platforms | 2.0.0 | |
NuGet | Microsoft.Win32.Registry | 4.5.0 | |
NuGet | System.Security.AccessControl | 4.5.0 | |
NuGet | System.Security.Principal.Windows | 4.5.0 | |
NuGet | Microsoft.Build.Tasks.Git | 1.1.1 | goaaats |
8 hidden needs (known safe NuGet packages).
Show log - Review
If our build system doesn't like pulling the Wine IPC Bridge exe from Blooym's PR, then I can ship it directly or it can probably be reworked to be downloaded on demand. |
I thought the build system could pull in files at build time but if not directly shipping would work fine too |
bleatbot, rebuild |
Outdated attemptBuilds failed, please check action output. Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
14 Needs (
|
Type | Name | Version | Reviewed by |
---|---|---|---|
NuGet | DiscordRichPresence | 1.2.1.24 | |
NuGet | Microsoft.NETCore.Platforms | 2.0.0 | |
NuGet | Microsoft.Win32.Registry | 4.5.0 | |
NuGet | System.Security.AccessControl | 4.5.0 | |
NuGet | System.Security.Principal.Windows | 4.5.0 | |
NuGet | Microsoft.Build.Tasks.Git | 1.1.1 | goaaats |
8 hidden needs (known safe NuGet packages).
Show log - Review
All builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
14 Needs (
|
Type | Name | Version | Reviewed by |
---|---|---|---|
NuGet | DiscordRichPresence | 1.2.1.24 | |
NuGet | Microsoft.NETCore.Platforms | 2.0.0 | |
NuGet | Microsoft.Win32.Registry | 4.5.0 | |
NuGet | System.Security.AccessControl | 4.5.0 | |
NuGet | System.Security.Principal.Windows | 4.5.0 | |
NuGet | Microsoft.Build.Tasks.Git | 1.1.1 | goaaats |
8 hidden needs (known safe NuGet packages).
Show log - Review
I'll need a Linux user to test this out. I think I adjusted paths correctly, but I'd like some eyes on that before its merged because I don't currently have a Linux machine ready for FFXIV. @Blooym if you've got a moment, can you pull the artifact? (Otherwise, I can poke the linux channel for a sacrifice) |
I spun up a fedora machine and it worked there. This should be fine to merge now |
Just tested and also worked fine |
Now includes a setting to automatically run a Wine IPC Bridge for Linux users (if you need one).
XIV On Mac users should continue to use the Wine IPC Bridge available in the XOM program settings.
This change has no effect for Windows users of the plugin.