[Testing] MagitekStratagem v0.10 - Builtin server #5207
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outdated attemptBuilds failed, please check action output. Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it! The average merge time for plugin updates is currently 9 hours.
17 Needs (✅ All reviewed)
9 hidden needs (known safe NuGet packages).Show log - Review |
bleatbot
added
build failed
|
Have you been able to investigate this / figure out a way forward? |
|
As far as I understand, there are .net packages that need to be whitelisted in order for the solution to build. |
|
Great, I'll hand it over to @goaaats to figure out then |
auto-merge was automatically disabled
January 2, 2025 11:57
Head branch was pushed to by a user without write access
|
Builds failed, please check action output. Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
17 Needs (
|
| Type | Name | Version | Reviewed by |
|---|---|---|---|
| NuGet | Microsoft.AspNetCore.SignalR.Client | 8.0.11 | |
| NuGet | Microsoft.AspNetCore.Connections.Abstractions | 8.0.11 | |
| NuGet | Microsoft.AspNetCore.Http.Connections.Client | 8.0.11 | |
| NuGet | Microsoft.AspNetCore.Http.Connections.Common | 8.0.11 | |
| NuGet | Microsoft.AspNetCore.SignalR.Client.Core | 8.0.11 | |
| NuGet | Microsoft.AspNetCore.SignalR.Common | 8.0.11 | |
| NuGet | Microsoft.AspNetCore.SignalR.Protocols.Json | 8.0.11 | |
| NuGet | System.IO.Pipelines | 8.0.0 | reiichi001 |
9 hidden needs (known safe NuGet packages).
Show log - Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing a followup idea to separating the plugin and tracker integration code:
This experimental new version of the plugin includes an entrypoint with which the plugin can be executed as the server.
This allows a separation of processes between the plugin + client, and native integrations + server, without requiring users download an external dependency, and mantaining all code compiled by the pipelines (hopefully this works!)
Unfortunately this also means the plugin itself is much bigger, as it has to bring along the required dependencies to run the AspNet server. Hopefully this won't be a major issue.