Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Add ContactsTracker #5217

Merged
merged 5 commits into from
Jan 5, 2025
Merged

[Testing] Add ContactsTracker #5217

merged 5 commits into from
Jan 5, 2025

Conversation

DueDine
Copy link
Contributor

@DueDine DueDine commented Dec 11, 2024

This is my first plugin, please let me know if there are any issues.


This plugin records the party composition at the end of each duty, similar to the in-game Contacts function. It also logs the entry method (e.g., Just select it or Duty Roulette), duration, jobs, and levels. Edge cases like disconnection, rejoining, and early termination are somewhat handled. However, I couldn’t extensively test certain scenarios like Solo Duties in MSQ or being kicked etc.

My current objective is to log duty data, which will help address user interest in metrics such as the average time spent on any roulette or the percentage of specific duties, like Crystal Tower in Alliance Raids.

Any Feedback is appreciate!

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 11, 2024

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@bleatbot bleatbot enabled auto-merge (squash) December 11, 2024 16:59
@reiichi001
Copy link
Contributor

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 12, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ContactsTracker [testing-live] 5fb5d20 v0.0.1.0 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet CsvHelper 33.0.1 goaaats
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. size-large Diff for this PR is large. labels Dec 12, 2024
auto-merge was automatically disabled December 12, 2024 07:45

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 12, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ContactsTracker [testing-live] 8c510aa v0.0.1.0 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet CsvHelper 33.0.1 goaaats
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 12, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ContactsTracker [testing-live] c069e65 v0.0.2.0 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet CsvHelper 33.0.1 goaaats
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 18, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ContactsTracker [testing-live] 1c6cc8d v0.1.0.0 - Repo (New plugin)
9 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet CsvHelper 33.0.1 goaaats
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. completed-rules-compliance This plugin is compliant with all rules. labels Dec 21, 2024
@DueDine
Copy link
Contributor Author

DueDine commented Dec 30, 2024

Just found a small bug in my code. Wondering what stage you are at and if already started reviewing my plugin. If yes, then I will defer the change to the next PR.
Commit Updated.

@reiichi001
Copy link
Contributor

Generally, we'll update the labels as things progress. You're free to update the PR with newer code during the process.

If someone is/was mid-code review, we can make a custom compare URL to diff between what was reviewed and what needs to be reviewed if relevant.

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ContactsTracker [testing-live] bbc06de v0.1.0.1 - Repo (New plugin)
3 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet CsvHelper 33.0.1 goaaats
2 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot removed pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. labels Dec 30, 2024
@philpax philpax added pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. and removed pending-code-review This plugin still needs code review. labels Dec 30, 2024
@philpax
Copy link
Contributor

philpax commented Jan 2, 2025

Apologies on the delay on the code review, it will hopefully be tested and merged soon 🙂

@nathanctech
Copy link
Contributor

nathanctech commented Jan 4, 2025

Loads and runs fine and seems to record needed data. Just a minor issue:

image

Seems the formatter is escaping the dashes in those two dungeon names.

Edit: I was informed that this issue is resolved in a later release, so may not be an issue now.

@DueDine
Copy link
Contributor Author

DueDine commented Jan 4, 2025

Loads and runs fine and seems to record needed data. Just a minor issue:

image

Seems the formatter is escaping the dashes in those two dungeon names.

Edit: I was informed that this issue is resolved in a later release, so may not be an issue now.

Thanks for your feedback. Yeah, this issue has been resolved in the latest version. I will submit a update once this PR merged.

image

@philpax philpax enabled auto-merge (squash) January 5, 2025 01:23
@philpax philpax added completed-testing This plugin has been tested. and removed pending-testing This plugin still needs to be tested. labels Jan 5, 2025
@philpax philpax merged commit f9edef1 into goatcorp:main Jan 5, 2025
2 checks passed
@philpax
Copy link
Contributor

philpax commented Jan 5, 2025

Congratulations on your first plugin added to the main Dalamud plugin repository!

As a first-time contributor, if you're in the XIVLauncher & Dalamud Discord server and would like to get access to the private developer channels for plugin feedback and others, please let us know your Discord handle and we'll grant you the role.

@DueDine
Copy link
Contributor Author

DueDine commented Jan 5, 2025

Congratulations on your first plugin added to the main Dalamud plugin repository!

As a first-time contributor, if you're in the XIVLauncher & Dalamud Discord server and would like to get access to the private developer channels for plugin feedback and others, please let us know your Discord handle and we'll grant you the role.

Thanks! My discord username is 'lamitt'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-rules-compliance This plugin is compliant with all rules. completed-testing This plugin has been tested. new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants