-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Add ContactsTracker #5217
Conversation
Outdated attemptThis is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you. Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging. Please hold! |
bleatbot, approve |
Outdated attemptAll builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
2 Needs (✅ All reviewed)
1 hidden need (known safe NuGet packages).Show log - Review |
Head branch was pushed to by a user without write access
Outdated attemptAll builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
2 Needs (✅ All reviewed)
1 hidden need (known safe NuGet packages).Show log - Review |
Outdated attemptAll builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
2 Needs (✅ All reviewed)
1 hidden need (known safe NuGet packages).Show log - Review |
Outdated attemptAll builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
9 Needs (✅ All reviewed)
7 hidden needs (known safe NuGet packages).Show log - Review |
|
Generally, we'll update the labels as things progress. You're free to update the PR with newer code during the process. If someone is/was mid-code review, we can make a custom compare URL to diff between what was reviewed and what needs to be reviewed if relevant. |
All builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
3 Needs (✅ All reviewed)
2 hidden needs (known safe NuGet packages).Show log - Review |
Apologies on the delay on the code review, it will hopefully be tested and merged soon 🙂 |
Thanks for your feedback. Yeah, this issue has been resolved in the latest version. I will submit a update once this PR merged. |
Congratulations on your first plugin added to the main Dalamud plugin repository! As a first-time contributor, if you're in the |
Thanks! My discord username is 'lamitt' |
This is my first plugin, please let me know if there are any issues.
This plugin records the party composition at the end of each duty, similar to the in-game Contacts function. It also logs the entry method (e.g., Just select it or Duty Roulette), duration, jobs, and levels. Edge cases like disconnection, rejoining, and early termination are somewhat handled. However, I couldn’t extensively test certain scenarios like Solo Duties in MSQ or being kicked etc.
My current objective is to log duty data, which will help address user interest in metrics such as the average time spent on any roulette or the percentage of specific duties, like Crystal Tower in Alliance Raids.
Any Feedback is appreciate!