Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XIVCombo v2.0.0.0 #5293

Merged
merged 4 commits into from
Jan 6, 2025
Merged

XIVCombo v2.0.0.0 #5293

merged 4 commits into from
Jan 6, 2025

Conversation

MKhayle
Copy link
Contributor

@MKhayle MKhayle commented Jan 1, 2025

Adoption of XIVCombo

  • A new UI, more modern and more fitting for the increasing amount of jobs has been added to XIVCombo.
  • Currently, all 65 existing combos have been kept while keeping feature parity as much as possible.
  • Your previous settings will not carry over this new version. A welcoming pop-up will warn you about it.
  • No new features, except the new UI. Maybe later, who knows? Updates should be more consistent from now on.
  • The GitHub repository will be cleaned up (issues and pull requests closed) as nothing there are relevant anymore.
  • Please use the Feedback feature of Dalamud to report any issues you would meet.

@MKhayle
XIVCombo v2.0.0.0
c367c4f 
## Adoption of XIVCombo
- A new UI, more modern and more fitting for the increasing amount of jobs has been added to XIVCombo.
- Currently, all 65 existing combos have been kept while keeping feature parity as much as possible.
- Your previous settings will not carry over this new version. A welcoming pop-up will warn you about it.
- No new features, except the new UI. Maybe later, who knows? Updates should be more consistent from now on.
- The GitHub repository will be cleaned up (issues and pull requests closed) as nothing there are relevant anymore.
- Please use the Feedback feature of Dalamud to report any issues you would meet.
@bleatbot bleatbot enabled auto-merge (squash) January 1, 2025 05:40
@bleatbot
Copy link
Collaborator

bleatbot commented Jan 1, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 4 hours.

Name Commit Status
✔️ XIVCombo [stable] f73c927 v2.0.0.0 - Diff (6898 lines, prev. 1.8.6.0)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the size-large Diff for this PR is large. label Jan 1, 2025
@MKhayle
Copy link
Contributor Author

MKhayle commented Jan 1, 2025

The codebase is totally different from the previous one, but should be similar to XIVUncombo's.

@MKhayle
Copy link
Contributor Author

MKhayle commented Jan 1, 2025

(Happy new year.)

auto-merge was automatically disabled January 1, 2025 22:13

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Jan 1, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ XIVCombo [testing-live] f73c927 v2.0.0.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the move channel This plugin is being moved to another channel. label Jan 1, 2025
@bleatbot
Copy link
Collaborator

bleatbot commented Jan 2, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ XIVCombo [testing-live] c8b69ac v2.0.0.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001 reiichi001 added the completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. label Jan 2, 2025
@reiichi001
Copy link
Contributor

I've gone through the code and also verified hooks/combos look to still be in line with what the legacy codebase had.

I'd like another PAC member to also take a look through for the util/replacer functions just in case I missed something.

@MKhayle
Update manifest.toml
f68684f 
update crashing issues with the theme
@MKhayle
Copy link
Contributor Author

MKhayle commented Jan 4, 2025

I updated the theme issues that were crashing (see https://discord.com/channels/581875019861328007/653504487352303619/1325094463223103531)

@bleatbot
Copy link
Collaborator

bleatbot commented Jan 4, 2025

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ XIVCombo [testing-live] 1187979 v2.0.0.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@karashiiro
Copy link
Contributor

I'd like another PAC member to also take a look through for the util/replacer functions just in case I missed something.

Sorry for the delay, on it now.

@karashiiro
Copy link
Contributor

Remaining code LGTM

@reiichi001 reiichi001 merged commit d36ef82 into goatcorp:main Jan 6, 2025
2 checks passed
@MKhayle MKhayle deleted the xivcombo branch January 6, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiichi001 reiichi001 reiichi001 approved these changes

Assignees
No one assigned
Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. move channel This plugin is being moved to another channel. size-large Diff for this PR is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MKhayle @bleatbot @reiichi001 @karashiiro