Skip to content

[Testing] Phlegma Dilemma #5360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[Testing] Phlegma Dilemma #5360

wants to merge 8 commits into from

Conversation

QLEDHDTV
Copy link

@QLEDHDTV QLEDHDTV commented Jan 17, 2025 •
edited
Loading

Phlegma Dilemma is an action rangefinder, visualizing the skill's range, radius, it's shape and the potential targets that can be hit if the action is AoE. Also provides a ruler to visualize the distance between the player and the NPC/object.

@bleatbot bleatbot enabled auto-merge (squash) January 17, 2025 02:05
@bleatbot
Copy link
Collaborator

bleatbot commented Jan 17, 2025 •
edited
Loading

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@philpax
Copy link
Contributor

philpax commented Jan 18, 2025

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Jan 18, 2025 •
edited
Loading

Outdated attempt

⚠️ No builds attempted! This probably means that your owners property is misconfigured.

Name Commit Status
👽 PhlegmaDillema [testing-live] 9939237 Not your plugin
Show log - Review

@bleatbot bleatbot added the new plugin This is a new plugin. label Jan 18, 2025
@reiichi001
Copy link
Contributor

The owner field will need to be adjusted to your github username, QLEDHDTV.

auto-merge was automatically disabled January 19, 2025 08:49

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Jan 19, 2025 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
❌ PhlegmaDillema [testing-live] 9939237 Build failed (Diff)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Jan 19, 2025
@bleatbot
Copy link
Collaborator

bleatbot commented Jan 19, 2025 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
😰 PhlegmaDillema [testing-live] 9939237 Build system error: DalamudPackager output not found, make sure it is installed
Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Jan 19, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ PhlegmaDilemma [testing-live] 9939237 v0.0.0.1 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Jan 19, 2025
@philpax philpax changed the title [Testing] Phlegma Dillema [Testing] Phlegma Dilemma Jan 19, 2025
@philpax
Copy link
Contributor

philpax commented Jan 19, 2025

Hi, this plugin is now in the review queue. Would you be able to include a screenshot of what it looks like in use?

@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Jan 19, 2025
@bleatbot
Copy link
Collaborator

bleatbot commented Jan 20, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ PhlegmaDilemma [testing-live] 9939237 v0.0.0.1 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot removed pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Jan 20, 2025
@philpax philpax added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. labels Jan 21, 2025
@philpax philpax added the pending-testing This plugin still needs to be tested. label Jan 21, 2025
@bleatbot
Copy link
Collaborator

bleatbot commented Feb 12, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ PhlegmaDilemma [testing-live] d993875 v0.2.0.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot removed pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Feb 12, 2025
@bleatbot
Copy link
Collaborator

bleatbot commented Feb 12, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ PhlegmaDilemma [testing-live] d993875 v0.2.0.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ PhlegmaDilemma [testing-live] 1692cb8 v0.2.1.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Feb 24, 2025
@philpax
Copy link
Contributor

philpax commented Mar 14, 2025

Apologies for the extremely late reply. After much internal deliberation, we have decided that this plugin runs the risk of upsetting the balance of combat, and as a result, we cannot allow it on the main plugin repository. We're very sorry about both the time it took to reach this decision, as well as the negative result, and we'll revise our combat rules in future to better clarify this.

@philpax philpax closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reiichi001 reiichi001

Labels
new plugin This is a new plugin. pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. size-large Diff for this PR is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QLEDHDTV @bleatbot @philpax @reiichi001