providers/ldap: Remove search group #10639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10639 +/- ##
==========================================
- Coverage 92.66% 92.46% -0.21%
==========================================
Files 736 736
Lines 36252 36277 +25
==========================================
- Hits 33593 33543 -50
- Misses 2659 2734 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BeryJu
force-pushed
the
providers/ldap/remove-search-group
branch
from
65d3341
to
602361d
Compare
kensternberg-authentik
approved these changes
Jul 29, 2024
| <ak-form-element-horizontal label=${msg("Search group")} name="searchGroup"> | ||
| <ak-search-select | ||
| .fetchObjects=${async (query?: string): Promise<Group[]> => { | ||
| const args: CoreGroupsListRequest = { |
There was a problem hiding this comment.
Fewer things make me happier than one less search-select in the product. :-)
BeryJu
force-pushed
the
providers/ldap/remove-search-group
branch
from
602361d
to
20e416b
Compare
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-75419d144309ceb9a72058a6e0c5bd6f77a574b9
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-75419d144309ceb9a72058a6e0c5bd6f77a574b9-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-75419d144309ceb9a72058a6e0c5bd6f77a574b9For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-75419d144309ceb9a72058a6e0c5bd6f77a574b9-arm64Afterwards, run the upgrade commands from the latest release notes. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
force-pushed
the
providers/ldap/remove-search-group
branch
from
20e416b
to
4c32b7e
Compare
BeryJu
force-pushed
the
providers/ldap/remove-search-group
branch
from
2b8a9b2
to
c264e9d
Compare
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 36.3%, saving 83.15 KB.
160 images did not require optimisation. |
tanberry
reviewed
Aug 14, 2024
tanberry
reviewed
Aug 14, 2024
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Jens L. <jens@beryju.org>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Jens L. <jens@beryju.org>
tanberry
reviewed
Aug 14, 2024
| [Users](../../user-group-role/user/index.mdx) and [Roles](../../user-group-role/roles/index.mdx) can be assigned the permission "Search full LDAP directory" to allow them to search the full LDAP directory and retrieve information about all users in the authentik instance. | ||
|
|
||
| :::info | ||
| Up to authentik version 2024.8 this was managed using the "Search group" attribute in the LDAP Provider, where users could be added to a group to grant them this permission. With authentik 2024.8 this is automatically migrated to the "Search full LDAP directory" permission, which can be assigned more flexibly. |
There was a problem hiding this comment.
So there is no action that users who upgrade to 2024.8 and later need to take, right?
There was a problem hiding this comment.
Please note many of us lost a lot of time on this #11548 (comment) since we did not get we had to work on object-level permission
tanberry
reviewed
Aug 14, 2024
tanberry
reviewed
Aug 14, 2024
tanberry
reviewed
Aug 14, 2024
| - **RBAC support for Blueprints and Terraform** | ||
|
|
||
| RBAC permissions for global/object level permissions for Users/Roles can now be managed via Blueprints and Terraform. This allows for the automatic configuration of permissions. | ||
|
|
||
| ## Upgrading | ||
|
|
||
| This release does not introduce any new requirements. |
There was a problem hiding this comment.
There is a new section in the Rel Notes template, with a link to the Upgrade docs. Let's make sure it gets into these Rel Notes.
tanberry
approved these changes
Aug 14, 2024
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Jens L. <jens@beryju.org>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Search group has been a thing on the LDAP provider since about 3 years, back when we didn't expose any of the RBAC things that we do now. Since we expose RBAC now we can use an object-level permission for this.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)