Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Refactor #10995

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

core: Refactor #10995

wants to merge 11 commits into from

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 20, 2024

Details

Misc refactors

  • Move common code from OAuth source/provider, SAML source/provider and LDAP provider into common package
  • Remove a lot of statically defined lists of models in blueprints
  • Make everything a bit more modular

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>

# Conflicts:
#	authentik/blueprints/v1/importer.py
#	authentik/core/models.py
#	authentik/sources/scim/models.py
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>

# Conflicts:
#	authentik/api/authentication.py
#	authentik/api/tests/test_auth.py
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner August 20, 2024 11:27
Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 603db60
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66c4d40cb011bd00089b0271

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 603db60
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66c4d40c08822c00089ca540

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 97.65101% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (d54718c) to head (603db60).
Report is 2 commits behind head on main.

Files Patch % Lines
authentik/root/celery.py 50.00% 4 Missing ⚠️
authentik/outposts/authentication.py 95.91% 2 Missing ⚠️
authentik/admin/api/system.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10995      +/-   ##
==========================================
- Coverage   92.70%   92.69%   -0.01%     
==========================================
  Files         736      740       +4     
  Lines       36360    36441      +81     
==========================================
+ Hits        33706    33780      +74     
- Misses       2654     2661       +7     
Flag Coverage Δ
e2e 49.25% <70.46%> (+0.06%) ⬆️
integration 25.07% <41.94%> (+0.01%) ⬆️
unit 90.24% <97.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-603db60a713fceeaf661d09ba722c8fc288c02fd
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-603db60a713fceeaf661d09ba722c8fc288c02fd-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-603db60a713fceeaf661d09ba722c8fc288c02fd

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-603db60a713fceeaf661d09ba722c8fc288c02fd-arm64

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant