Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: expiring model: don't synchronously delete #11688

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rissson
Copy link
Member

@rissson rissson commented Oct 15, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Oct 15, 2024
@rissson rissson requested a review from a team as a code owner October 15, 2024 12:15
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 929e42d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/670e654d2e582c0008ebe45a

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 929e42d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/670e654db4a16c0008317cfb

@rissson
Copy link
Member Author

rissson commented Oct 15, 2024

Need to make sure we don't break like #3233

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (0a1d283) to head (929e42d).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11688      +/-   ##
==========================================
- Coverage   92.77%   92.51%   -0.26%     
==========================================
  Files         736      736              
  Lines       36603    36613      +10     
==========================================
- Hits        33957    33874      -83     
- Misses       2646     2739      +93     
Flag Coverage Δ
e2e 48.76% <85.71%> (-0.63%) ⬇️
integration 24.98% <85.71%> (+0.02%) ⬆️
unit 90.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson marked this pull request as draft October 15, 2024 12:26
@rissson
Copy link
Member Author

rissson commented Oct 15, 2024

This definitely breaks other things

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson marked this pull request as ready for review October 15, 2024 12:52
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-929e42d3f2cc393b4d20ac6d3336d1aa817e9087
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-929e42d3f2cc393b4d20ac6d3336d1aa817e9087-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-929e42d3f2cc393b4d20ac6d3336d1aa817e9087

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-929e42d3f2cc393b4d20ac6d3336d1aa817e9087-arm64

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant