Added conditions to the subqueries that use union #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisei24
commented
Nov 11, 2024
Comment on lines
+269
to
+272
| goqu.L("NULL::INTEGER").As("exec_block_number"), | ||
| goqu.L("NULL::TEXT").As("graffiti_text"), | ||
| goqu.L("NULL::BYTEA").As("fee_recipient"), | ||
| goqu.L("NULL::NUMERIC").As("el_reward"), |
There was a problem hiding this comment.
This got quite complicated here.
As soon as scheduledDs gets a LIMIT added to it the Union goqu method determines that it now needs to wrap itself, meaning SELECT ... => SELECT * FROM ( SELECT ... LIMIT ...) AS t1
As a result of that it could no longer correctly identify the types of our NULL values.
The only solution I found is adding such casts.
Goqu also doesn't allow a Cast(...) method on a V(...) object.
peterbitfly
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
blocksDsandscheduledDssubqueries now also directly apply the limitations from pagination and limit with ordering.