-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/15.0/19853/_add_report_description #4
Feature/15.0/19853/_add_report_description #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested on this pass. Just a couple questions and nitpicks
addons/web/static/src/legacy/frontend/keyboard_navigation_mixin.js
Outdated
Show resolved
Hide resolved
@Jessica-BlueStingray Let's keep this moving 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally tested, looking good overall 👍
Just one bit of commented out code to omit.
My only concern is this part of the requirements:
Responsive design reclaims that whitespace for smaller screen widths, let’s hide the description as necessary.
I tested this out, and it does not appear to hide, and sometimes pushes the search bar off of the viewing area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not retested. Looking good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not retested but I did test previously ✅
b1211e8
to
43dd1ac
Compare
@traviswaelbro @dpsholtes @toddythebody This PR was rebased and is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not retested
5f733b9
to
9f92494
Compare
f1a0152
to
3ebff71
Compare
@Jessica-BlueStingray Leaving this for you to merge as you see fit |
Waiting on Adam to see if the other PR with this code is going to be merged there or not. Still not really sure on what is the next move there. |
Are you referring to metricwise#20, where there was some discussion about |
3ebff71
to
e9fa865
Compare
e9fa865
to
9c52041
Compare
Add report description [19853]
A description area was added to the Control Panel between the View name and the Search Area.
To test:
view_description
> Save > Refresh pageview_description.mp4
If it doesn't show up at first, refresh the browser (Ctrl+R) one or more times, going to another view and coming back to the previous view also works..