Fix issue with Que being unable to exit cleanly #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rack::Puma::Handler` will `trap` signals which prevents que from receiving the SIGINT and SIGTERM signals - causing K8s to eventually SIGTERM the pods after some time.
|
Couldn't see anything in the spec https://github.com/teamcapybara/capybara/blob/0480f90168a40780d1398c75031a255c1819dce8/spec/server_spec.rb but can we write a test for this? |
JoeSouthan
force-pushed
the
joesouthan-puma-server
branch
from
4563c31 to
4c1af58
Compare
ankithads
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rack::Puma::Handlerwilltrapsignals which prevents que from receiving theSIGINTandSIGTERMsignals - causing K8s to eventuallySIGTERMthe pods after some time.Inspired by Capybara