Merge pull request #888 from pmsl/bugfix/craned-rbac

change update workload to update workload status
gocrane · Jan 18, 2024 · 5c18026 · 5c18026
2 parents 6d7758e + 8380d7f
commit 5c18026
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/deploy/craned/rbac.yaml b/deploy/craned/rbac.yaml
@@ -72,7 +72,16 @@ rules:
   - get
   - list
   - watch
-  - update
+- apiGroups:
+    - apps
+  resources:
+    - daemonsets/status
+    - deployments/status
+    - deployments/scale
+    - statefulsets/status
+    - statefulsets/scale
+  verbs:
+    - update
 - apiGroups:
   - autoscaling
   resources:

diff --git a/pkg/controller/recommendation/updater.go b/pkg/controller/recommendation/updater.go
@@ -99,7 +99,8 @@ func (c *RecommendationController) UpdateRecommendation(ctx context.Context, rec
 
 		if needUpdate {
 			unstructed.SetAnnotations(annotation)
-			err = c.Client.Update(ctx, unstructed)
+			//Convergence craned permissions
+			err = c.Client.Status().Update(ctx, unstructed)
 			if err != nil {
 				return false, fmt.Errorf("update target annotation failed: %v. ", err)
 			}