Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil panic in caculateCPUUsage #848

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

borgerli
Copy link
Collaborator

@borgerli borgerli commented Aug 8, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #847

Special notes for your reviewer:

@borgerli borgerli requested a review from payall4u August 8, 2023 07:13
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-08-08 17:22
Git Version: c69fda3

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-848-c69fda3 docker pull gocrane/crane-agent:pr-848-c69fda3
dashboard:pr-848-c69fda3 docker pull gocrane/dashboard:pr-848-c69fda3
metric-adapter:pr-848-c69fda3 docker pull gocrane/metric-adapter:pr-848-c69fda3
craned:pr-848-c69fda3 docker pull gocrane/craned:pr-848-c69fda3

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-848-c69fda3 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-848-c69fda3 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-848-c69fda3 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-848-c69fda3 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-848-c69fda3 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-848-c69fda3
dashboard:pr-848-c69fda3 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-848-c69fda3
metric-adapter:pr-848-c69fda3 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-848-c69fda3
craned:pr-848-c69fda3 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-848-c69fda3

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-848-c69fda3 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-848-c69fda3 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-848-c69fda3 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-848-c69fda3 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-848-c69fda3 docker pull ghcr.io/gocrane/crane/crane-agent:pr-848-c69fda3
dashboard:pr-848-c69fda3 docker pull ghcr.io/gocrane/crane/dashboard:pr-848-c69fda3
metric-adapter:pr-848-c69fda3 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-848-c69fda3
craned:pr-848-c69fda3 docker pull ghcr.io/gocrane/crane/craned:pr-848-c69fda3

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-848-c69fda3 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-848-c69fda3 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-848-c69fda3 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-848-c69fda3 crane/crane

Copy link
Collaborator

@payall4u payall4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@payall4u payall4u merged commit b579460 into gocrane:main Aug 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when caculateCPUUsage
2 participants