Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsp indicator isolated from ehpa #881

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

whitebear009
Copy link
Contributor

@whitebear009 whitebear009 commented Dec 28, 2023

What type of PR is this?

optimize

What this PR does / why we need it:

Currently the tsp indicator is calculated in ehpaList. If the tsp is created separately (not through ehpa), then the indicators of this tsp will be gone.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-12-28 11:06
Git Version: 2982d0f

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-881-2982d0f docker pull gocrane/crane-agent:pr-881-2982d0f
dashboard:pr-881-2982d0f docker pull gocrane/dashboard:pr-881-2982d0f
metric-adapter:pr-881-2982d0f docker pull gocrane/metric-adapter:pr-881-2982d0f
craned:pr-881-2982d0f docker pull gocrane/craned:pr-881-2982d0f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-881-2982d0f \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-881-2982d0f \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-881-2982d0f \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-881-2982d0f crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-881-2982d0f docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-881-2982d0f
dashboard:pr-881-2982d0f docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-881-2982d0f
metric-adapter:pr-881-2982d0f docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-881-2982d0f
craned:pr-881-2982d0f docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-881-2982d0f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-881-2982d0f \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-881-2982d0f \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-881-2982d0f \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-881-2982d0f crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-881-2982d0f docker pull ghcr.io/gocrane/crane/crane-agent:pr-881-2982d0f
dashboard:pr-881-2982d0f docker pull ghcr.io/gocrane/crane/dashboard:pr-881-2982d0f
metric-adapter:pr-881-2982d0f docker pull ghcr.io/gocrane/crane/metric-adapter:pr-881-2982d0f
craned:pr-881-2982d0f docker pull ghcr.io/gocrane/crane/craned:pr-881-2982d0f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-881-2982d0f \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-881-2982d0f \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-881-2982d0f \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-881-2982d0f crane/crane

@whitebear009
Copy link
Contributor Author

@qmhu PTAL, thx

Copy link
Contributor

@mfanjie mfanjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfanjie mfanjie merged commit 3fa7240 into gocrane:main Mar 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants