Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README.md] Enhance linking and grammar #543

Merged
merged 5 commits into from
May 13, 2024
Merged

[README.md] Enhance linking and grammar #543

merged 5 commits into from
May 13, 2024

Conversation

fvsamson
Copy link
Contributor

@fvsamson fvsamson commented May 7, 2024

  • Fix grammar and enhance wording.
  • Consecutive web-links without non-linked, non-whitespace characters are … problematic; thus rectified.
  • References to outdated specifications do not make much sense, hence omitted, especially as the link to the current specification immediately followed.

fvsamson added 3 commits May 7, 2024 19:41
- Consecutive web-links without non-linked, non-whitespace characters are … problematic; thus rectified.
- References to outdated specifications do not make much sense, hence omitted, especially as the link to the current specification immediately followed.
Copy link
Member

@bernhardreiter bernhardreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "An implementation of a" -> "Implements a" is an improvement, but now a link to the main body of the standard is missing. (See comment).

README.md Outdated Show resolved Hide resolved
@bernhardreiter bernhardreiter requested a review from tschmidtb51 May 8, 2024 06:38
Copy link
Collaborator

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fvsamson fvsamson requested a review from bernhardreiter May 13, 2024 08:32
Copy link
Member

@bernhardreiter bernhardreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@bernhardreiter bernhardreiter merged commit 7a53478 into gocsaf:main May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants