Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution(java): Problems 229 and 287 #57

Merged
merged 2 commits into from
Oct 8, 2023
Merged

solution(java): Problems 229 and 287 #57

merged 2 commits into from
Oct 8, 2023

Conversation

PrashantDesale2004
Copy link
Contributor

#43 Added the soluition of Majority Element ll in java and cpp with logic behind how to solve the problem with step-by-step

@godkingjay godkingjay self-requested a review October 7, 2023 23:47
@godkingjay godkingjay added hacktoberfest-accepted Hacktoberfest participation. hacktoberfest Hacktoberfest issue. solution labels Oct 7, 2023
@godkingjay godkingjay linked an issue Oct 7, 2023 that may be closed by this pull request
Copy link
Owner

@godkingjay godkingjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions. However, it seems like you put your C++ solution in the wrong directory. You put it in /Medium/287. Find Duplicate Number instead of /Medium/229. Majority Element II.

Also, please don't overwrite previous solutions unless they have errors. If you're adding a new solution on a problem but it already has an existing solution, you may do it like this:

// Solution 1
class Solution {
	/*
	 * Solution 1
	 */
}

// Solution 2
class Solution {
	/*
	 * Solution 2
	 */
}

@godkingjay godkingjay changed the title #43 problem: 229. Majority Element II solution(java): Problems 229 and 287 Oct 8, 2023
Copy link
Owner

@godkingjay godkingjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions!

@godkingjay godkingjay merged commit 25ad406 into godkingjay:master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest issue. hacktoberfest-accepted Hacktoberfest participation. solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem: 229. Majority Element II
2 participants