Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add required attribute to editor-plugin tutorial #34

Merged
merged 1 commit into from
Feb 9, 2024
Merged

add required attribute to editor-plugin tutorial #34

merged 1 commit into from
Feb 9, 2024

Conversation

vortexofdoom
Copy link
Contributor

@vortexofdoom vortexofdoom commented Feb 9, 2024 •
edited
Loading

See title. Pasting the code directly from the tutorial will cause an error.

If we'd rather keep it to a self-contained impl block, I could change it to something like

#[godot_api]
impl MyEditorPlugin {}

Bromeon
Bromeon approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bromeon Bromeon added the error Mistake in the book label Feb 9, 2024
@Bromeon Bromeon merged commit b490ff0 into godot-rust:master Feb 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon approved these changes

Assignees
No one assigned
Labels
error Mistake in the book
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vortexofdoom @Bromeon