Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of android readme #42

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

TCROC
Copy link
Contributor

@TCROC TCROC commented Apr 20, 2024

This is just a first draft for Android. Please critique it and let me know what changes you want made. Android definitely has quite a few steps to it, but good news is: IT WORKS! :)

Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This is a very helpful introductory guide to Android! 🙂

Several formatting issues -- I mentioned them in some comments, but make sure they are applied to the whole page. Examples:

  • Proper capitalization of names like "Godot", "Linux" or "Android" and abbreviations like "CLI" and "NDK".
  • No double spaces between sentences, ever.
  • Single instead of double backticks for monospace.

Also check that CI passes, it already fixes some of those issues.

src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
@Bromeon Bromeon added the new-topic New content added to the book label Apr 22, 2024
@Bromeon
Copy link
Member

Bromeon commented May 23, 2024

@TCROC it's been a month, any update/response to my comments? 🙂

@TCROC
Copy link
Contributor Author

TCROC commented May 23, 2024

@Bromeon I agree them! :) I just have to get around to updating the PR with them. Probably going to once I get ios and mac working properly on this next part in my game. Which will also include PRs to the book for ios and mac support :)

@TCROC TCROC marked this pull request as ready for review June 27, 2024 18:07
@TCROC TCROC force-pushed the android branch 2 times, most recently from ea255fc to 9d45c48 Compare June 27, 2024 19:47
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! ☺️

src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
@TCROC TCROC force-pushed the android branch 2 times, most recently from dce08f5 to 5f59a17 Compare June 29, 2024 15:35
@TCROC
Copy link
Contributor Author

TCROC commented Jun 29, 2024

I believe I fixed all suggestions! :) Let me know if you find anything else! :)

src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
src/toolchain/export-android.md Outdated Show resolved Hide resolved
@TCROC TCROC force-pushed the android branch 2 times, most recently from f1439be to 18adb72 Compare June 29, 2024 16:33
@TCROC
Copy link
Contributor Author

TCROC commented Jun 29, 2024

Suggestions have been applied :) Ready for further review :)

@Bromeon Bromeon merged commit 04c47ae into godot-rust:master Jun 29, 2024
4 checks passed
@Bromeon
Copy link
Member

Bromeon commented Jun 29, 2024

Thank you very much for all the improvements! 😊

@TCROC
Copy link
Contributor Author

TCROC commented Jun 29, 2024

Thank you very much for all the improvements! 😊

Absolutely! Glad to get additional platforms officially into the docs! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-topic New content added to the book
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants