Skip to content

FindInFiles: Show the number of matches for each file #110770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

FindInFiles: Show the number of matches for each file #110770

merged 1 commit into from
Sep 23, 2025
+25 −10

Conversation

arkology
Copy link
Contributor

Closes godotengine/godot-proposals#13225

godot.windows.editor.dev.x86_64_H5VB72ciw1.mp4

Implementation notes:

  • The number of file matches is displayed only after the search is completed. This means that information about the number of file matches is not displayed during the search. This can be seen in the video above.
  • I used " (" + vformat(TTRN("%d match", "%d matches", file_matches_count), file_matches_count) + ")" instead of vformat(TTRN(" (%d match)", " (%d matches)", file_matches_count), file_matches_count) to reuse existing transfers.

@arkology arkology requested a review from a team as a code owner September 22, 2025 07:17
@AThousandShips AThousandShips added this to the 4.x milestone Sep 22, 2025
Calinou
Calinou approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 23, 2025
@Repiteo Repiteo merged commit 4b8cd07 into godotengine:master Sep 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 23, 2025

Thanks!

@arkology arkology deleted the find-in-files-count branch September 23, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.

FindInFiles: Show the number of matches for each file
4 participants
@arkology @Repiteo @Calinou @AThousandShips