Skip to content

Conversation

@Arnklit
Copy link
Contributor

@Arnklit Arnklit commented Nov 6, 2025

This adds box scaling to the Value Tracks Editor, similar to what was added to the Bezier Track Editor
This would resolve godotengine/godot-proposals#3532

godot.windows.editor.dev.x86_64_fO9duTEQA2.mp4
  • hide the lines if they are outside the range
  • make the scale to offset by 12 pixels so it stays offset like the handle is
  • make inverted scaling work
  • make the handle offset correct when doing inverted scaling
  • update the lines connecting identical keys when scaling
  • adjust the rects so they are 5 pixels pushed away from the keys so it's easier to move the keys.
  • key snapping
  • snap the scaling handle?

This ended up being a bit of a bigger PR than I had hoped, so it needs a thorough review. I'll set it for draft now until I've had the chance to give it a thorough lookover myself.

@Arnklit Arnklit requested a review from a team as a code owner November 6, 2025 23:36
@Arnklit Arnklit marked this pull request as draft November 6, 2025 23:36
@Arnklit
Copy link
Contributor Author

Arnklit commented Nov 6, 2025

I realise now that this might collide with the work in #105151

I had not realised someone else was working on this.

EDIT: Having a look at that PR, it looks like it was decided to go with an implementation more similar to what I have done here, so it might make sense to supercede.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add easier way to scale keyframes in AnimationPlayer Editor

2 participants