-
-
Notifications
You must be signed in to change notification settings - Fork 23.5k
Add scroll hints to ScrollContainer and Tree
#112491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YeldhamDev
wants to merge
1
commit into
godotengine:master
Choose a base branch
from
YeldhamDev:deep_within_the_shadows_lays_scrollable_content
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add scroll hints to ScrollContainer and Tree
#112491
YeldhamDev
wants to merge
1
commit into
godotengine:master
from
YeldhamDev:deep_within_the_shadows_lays_scrollable_content
+268
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dd6fd90 to
60c4ff5
Compare
60c4ff5 to
ab554d5
Compare
Member
Author
|
YeldhamDev
commented
Nov 7, 2025
Comment on lines
+636
to
+639
| if (rtl) { | ||
| // TODO: Find out why this is even necessary. | ||
| scroll_hint_top_left->set_position(Point2(0, scroll_hint_top_left->get_position().y)); | ||
| } |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no clue why, but this is necessary for this hint to be positioned properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds scroll hints (indicators that there are still scrollable content towards a direction) to both
ScrollContainer(horizontal and vertical) andTree(only vertical). The default behavior is to hide them, but one can also set them to appear on both opposite sides, or just in one.One of the objectives of this is to make godotengine/godot-proposals#13581 (comment) possible.
Screencast_20251106_230651.webm
This PR also does a small reordering of properties of those classes when shown in the inspector.