fix: plugins list json #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xCodeMuse
approved these changes
Dec 24, 2024
triprjt
reviewed
Jan 21, 2025
src/commands/plugin/index.ts
Outdated
| const availablePlugins = JSON.parse(pluginsData); | ||
|
|
||
| // Map to the format expected by the UI | ||
| const pluginNames = availablePlugins.map((plugin: { value: any; name: any; description: any }) => ({ |
There was a problem hiding this comment.
add types for value, name, description
src/commands/plugin/index.ts
Outdated
| Description: plugin.description, | ||
| })); | ||
|
|
||
| console.log("Available plugins:", pluginNames); |
| Description: plugin.description, | ||
| }) | ||
| ); | ||
|
|
||
| const commonPlugins = pluginNames.filter( | ||
| (plugin: { value: string | number }) => pluginsList[plugin.value] |
There was a problem hiding this comment.
do we really need the number type, in value?
src/commands/plugin/index.ts
Outdated
| const availablePlugins = JSON.parse(pluginsData); | ||
|
|
||
| // Map to the format expected by the UI | ||
| const pluginNames = availablePlugins.map((plugin: { value: any; name: any; description: any }) => ({ |
There was a problem hiding this comment.
this code is repeated. Please see line #227
Merge the code if necessary.
src/commands/plugin/index.ts
Outdated
| const availablePlugins = JSON.parse(pluginsData); | ||
|
|
||
| // Map to the format expected by the UI | ||
| const pluginNames = availablePlugins.map((plugin: { value: any; name: any; description: any }) => ({ |
There was a problem hiding this comment.
same code repeated. Please check once
…into fix/plugins-list-json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"npm search @godspeedsystems/plugins --json" is not giving accurate results,
So parsed a json (containing available plugins) to all three functions to add, remove, update godspeed plugins.