fix(msl): use references (&) instead of pointers (*) for buffer parameters#39
Merged
fix(msl): use references (&) instead of pointers (*) for buffer parameters#39
Conversation
…eters Buffer parameters now generate 'constant T& name' instead of 'constant T* name'. Pointer syntax required '->' for member access while expression writer generates dot access, causing Metal compilation errors on Apple Silicon (ui#23).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&) instead of pointers (*) — fixes Metal shader compilation crash on Apple Silicon (M3)u.viewport), which requires reference syntax (constant T& u), not pointer syntax (constant T* uwhich needs->)Fixes gogpu/ui#23
Changes
msl/functions.go—*→&for buffer parameter generationmsl/expressions.go—pointerNeedsDerefreturns false (references don't need(*ptr)wrapping)CHANGELOG.mdupdatedTest plan
go test ./snapshot/...)GOWORK=off go test ./...)GOWORK=off golangci-lint run)