-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamping building and release with dagger multibuild pipeline #25
Conversation
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Awesome! I'll looking forward to try this out! |
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Hello @Vad1mo @OrlinVasilev |
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: Bishal Das <70086051+bishal7679@users.noreply.github.com>
@Vad1mo could you pls take a look on it. Now with dagger CI it's also adding release binary to multiple pkg manager and its workflow files running successfully! |
Signed-off-by: Bishal Das <70086051+bishal7679@users.noreply.github.com>
build go is building not the harbor cli but rather the build.go file Something lke this: |
can you also provide instrustion on how to test ideally locally the release and pull-request flow? |
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: Bishal Das <70086051+bishal7679@users.noreply.github.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
To test the 1. Release
NOTE:- The below command will automatically be triggered whenever a new tag will be pushed
2. Pull-request
NOTE:- This pull-request action flow will be triggered whenever a new pull-request come to this repo. At first it will check whether all test files are passed or not then will create a --snapshot for the current release and will signal for ready-to-merge I hope this will help!! |
Signed-off-by: Bishal Das <70086051+bishal7679@users.noreply.github.com>
Signed-off-by: Bishal Das <70086051+bishal7679@users.noreply.github.com>
We need to make sure that this PR replaces the current Makefile. Also remove in the PR, the Makefile. |
also update the Readme.md, explainin how to build and test locally |
The name of the generated SPDX file should have this pattern |
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: Bishal Das <70086051+bishal7679@users.noreply.github.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
What is the status here ? 🤔 |
Currently migrating from using dagger package to dagger module like |
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
@bishal7679 please upload screenshots of the features added. |
Now we are able to build harbor cli through dagger call by this command dagger call build-harbor --directory-arg . export --path=./ But the obstacle for this PR is with the release part. Getting again a weird go version error in go.mod even though its carrying the version with 1.22.5 |
682cd1e
to
733a48d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bishal7679 the DCO is missing -> https://github.com/goharbor/harbor-cli/pull/25/checks?check_run_id=27820215347
@bishal7679 please squash and sign the commits. |
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com> updated goreleaser and workflow Signed-off-by: bishal7679 <bishalhnj127@gmail.com> updated github workflow Signed-off-by: bishal7679 <bishalhnj127@gmail.com> updated github workflow Signed-off-by: bishal7679 <bishalhnj127@gmail.com> updated github workflow Signed-off-by: bishal7679 <bishalhnj127@gmail.com> updated github workflow Signed-off-by: bishal7679 <bishalhnj127@gmail.com> updated github workflow Signed-off-by: bishal7679 <bishalhnj127@gmail.com> updated github workflow Signed-off-by: bishal7679 <bishalhnj127@gmail.com> updated gorelaser and syft version Signed-off-by: bishal7679 <bishalhnj127@gmail.com> updated workflow Signed-off-by: bishal7679 <bishalhnj127@gmail.com> changed tag push branch Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
@bishal7679 please fix DCO and the failing test. https://github.com/goharbor/harbor-cli/actions/runs/10074141257/job/27969136509?pr=25 |
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
do you require any help @bishal7679 |
Closing as completed by #133 |
Fixing #22
Previous State
Current Behavior
build.go
release
andpull_request
event separately [addeddeb
rpm
package based binary release with architecture]brew install
supportgoharbor
namedhomebrew-tap
for uploading the tap formula which will eventually be used during brew installationScreenshot
PS:- should be removed
go.work
&go.work.sum
file after using the release pipeline once!//cc @Vad1mo